search

libretime / libretime-debian-packaging

Debian packaging for LibreTime
Other
8 stars 3 forks source link

Did not complete #4

Closed JohnnyC1951 closed 5 years ago

JohnnyC1951 commented 5 years ago

I told it to keep my airtime and LS config and got this: Note missing URL and interrupted message. The Backend says it is running alpha 5

-----------------------------------------------------
                * Basic Setup DONE! *                

 To get started with Airtime, visit             
 or, if you've set up your own web configuration,    
 the Airtime webroot on your webserver               
-----------------------------------------------------
W: Operation was interrupted before it could finish
JohnnyC1951 commented 5 years ago

It still works. By the way.

JohnnyC1951 commented 5 years ago

Update. I did an apt-get remove and reinstall. This time it did not ask any questions at all and completed. It still reports Alpha 5 Clock Icon in UI is not the new one.

JohnnyC1951 commented 5 years ago

Update. I found out why I did not see any changes. It had installed to another path The installer had installed it to: /usr/share/airtime/airtime_mvc But the station is actually running on : /usr/share/airtime/php/airtime_mvc

Robbt commented 5 years ago

Ahh good catch. Yeah we modified the install path in the early days of LibreTime.

paddatrapper commented 5 years ago

Which is the correct path according to the ./install script? The deb should follow that, so if it doesn't, the deb needs changing (airtime_mvc install location and the apache config)

hairmare commented 5 years ago

FWIW I don't really think that the install script should be considered our gold standard... Currently my CentOS packages install the webroot to /var/www/libretime/airtime_mvc/public/ with vendorized php deps in /var/www/libretime/vendor/. I'm not sure what legacy upstream did in their packages but we should probably focus on using default distro paths for most things. In the case of CentOS it's below /var/www/ to ensure that SELinux can be used without having to write heaps of policy.

JohnnyC1951 commented 5 years ago

I am pretty sure that I will not be the only one that tries to use the deb to upgrade. From a user perspective, it did not fully detect that is was an upgrade from a previous LT install, which it was, resulting in system that was still running a previous version of LT. May I suggest that it checks the old path install, and at least ask what to do? Putting it below /var/www seems sensible and solves permissions issues at a stroke. But, was there a security reason why they did not, like keeping the application folder outside any possible webroot, and in doing so, protect the system? Also I would prefer it if .install and deb did not zap the whole public folder, thus taking out anything else I had in there. I can live with it as it is, just expressing a preference.

paddatrapper commented 5 years ago

@hairmare I'll follow Debian policy as first priority and then the installer. I actually need to check where Debians's canonical install location for Web-data is (/var/www or /usr/share

@JohnnyC1951 I'll look into detecting existing installs and trying to migrate them. How did you install originally? Can you provide a directory/file location listing for that so I know what to look for?

JohnnyC1951 commented 5 years ago

It was an alpha 5 tarball. libretime-3.0.0-alpha.5.tar.gz The old installer put it at /usr/share/airtime/php/airtime_mvc So, I think a test for the existence of /usr/share/airtime/php/airtime_mvc/index.php would be enough.

JohnnyC1951 commented 5 years ago

I think its probably simpler just to zap the old airtime_mvc folder (with a warning) and make a new apache config and install. BUT KEEP THE OLD STOR & DATABASE :) I think it would be useful (at least for me and anyone else making and using add-ons) to store the current install path in airtime.config

paddatrapper commented 5 years ago

This has been fixed in d61e90d9c16fa9b5758a5f7829eea2ca240a34f8 and 37f61063703fb58fb2291dd4ba297a2790fae150. It removes /usr/share/airtime and modifies the apache config to use /var/www/airtime. It will warn that it is an existing installation that is being overwritten.