search

libretiny-eu / upk2esphome

Automatically generate ESPHome YAML for Tuya IoT devices
https://upk.libretiny.eu/
MIT License
13 stars 4 forks source link

switch: only use PWM for PWM lights #11

Closed Habbie closed 6 months ago

Cossid commented 8 months ago

Eventually we may need a way to change that pin list based on platform/board, if we ever start supporting realtek or esp8266 at some point.

Habbie commented 8 months ago

That's a very good point.

kuba2k2 commented 6 months ago

@Habbie Hi, can this be merged? The PR is still marked as draft.

Habbie commented 6 months ago

hi! I marked it as draft because it considers specific pins assuming this project targets only one platform, which might change in the future. How about I add a FIXME comment for that and unmark it as draft?

kuba2k2 commented 6 months ago

You can do that if you need to, but keep in mind that the UPK project architecture would require a major restructure anyway, if we ever wanted to support other platforms.

Habbie commented 6 months ago

Yes, true. That means that we might as well merge. I'll add a few comments soon.

Habbie commented 6 months ago

amended my commit with a new comment, now marking Ready for review