search

libretro-mirrors / beetle-saturn-libretro

Standalone port of Mednafen Saturn to the libretro API.
GNU General Public License v2.0
62 stars 42 forks source link

Missing redump set crcs #35

Open i30817 opened 7 years ago

i30817 commented 7 years ago

I noticed after making readable the Saturn database rb that you're only checking the .cue files md5sum. I applaud this development, and it's quite enough to uniquely identify sets and still allow hardpatches to function, if the set is not 'plain iso'. I wish it happened in other consoles rbs too.

However, they (redump cue files ids and crcs) aren't on the Saturn rb. The redump set of cue files (of this and other consoles) can be dowloaded from their site easily, i don't really understand why you have others and not them. The only set where i know for sure i wouldn't prefer redump is dreamcast* (or some hacks that need another set dump).

I noticed this after the scan of about 5 games of the redump Saturn set came up empty, and i checked the games in the rb.

*Using the same indirection and trust of the user to have verified sets, there i'd prefer a scan of the gdi files from TOSEC, since people say redump has strange dumps here. Not sure it works for hacks because that format has what looks like byte indexes though.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/46541762-missing-redump-set-crcs?utm_campaign=plugin&utm_content=tracker%2F43093589&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F43093589&utm_medium=issues&utm_source=github).
i30817 commented 7 years ago

Mmmm. No, this is mostly wrong. The redump cue crcs are there but what's happening is that the playlist is not being created by some reason after i scan the directory with the games. I don't know what's happening then.

RA verbose says something like this when this is happening:

RetroArch [INFO] :: Parsing CUE file '/media/i30817/backup/Documents/Games/Sega Saturn/Radiant Silvergun (Japan)/Radiant Silvergun (Japan).cue'... RetroArch [INFO] :: Found first data track on file '/media/i30817/backup/Documents/Games/Sega Saturn/Radiant Silvergun (Japan)/Radiant Silvergun (Japan) (Track 01).bin+0' RetroArch [INFO] :: Reading first data track... RetroArch [INFO] :: Comparing with known magic numbers... RetroArch [INFO] :: Parsing CUE file '/media/i30817/backup/Documents/Games/Sega Saturn/Dragon Force (USA)/Dragon Force (USA).cue'... RetroArch [INFO] :: Found first data track on file '/media/i30817/backup/Documents/Games/Sega Saturn/Dragon Force (USA)/Dragon Force (USA) (Track 1).bin+0' RetroArch [INFO] :: Reading first data track... RetroArch [INFO] :: Comparing with known magic numbers...

Why .bin+0 ? The cue files only reeally have the .bin unless the +0 is supposed to be a strange extra \0. Strange because these are redump verified as the crc confirms. Also it doesn't say if it failed or succeed.

i30817 commented 7 years ago

A ancient Lakka bug

https://github.com/libretro/Lakka/issues/377

with a similar problem said that it was because the filenames had spaces. I find that hard to believe, but never the less tried to remove all spaces from the parent dirs, the names and the cue, and scan still returned zilch.. Well, the crc32 of the cue file would have changed when i edited it to remove the spaces, so i'm not too surprised it failed.