orbea
commented
8 years ago I checked my old packages and found this issue did not used to exist so I did a git bisect and got this.
$ git bisect bad
6afd540ac19ec29b48ecf1997136d5a31ab7fd1e is the first bad commit
commit 6afd540ac19ec29b48ecf1997136d5a31ab7fd1e
Author: rz5 <razevok@gmail.com>
Date: Fri Mar 11 18:50:39 2016 +0000
Prevent camera flip and add 3 core options.
Right analog sensitivity and deadzone size and invert aim.
:040000 040000 b2e37add493b5ddd30690129c9c58f0416c8c51c d787c736e8b4aaaa0c8e7678dc2e17a41811d2e3 M libretro
:040000 040000 ac8ee3c3d6c6c745b0437cdeee0691b39aa89d59 3e8f83018e0aaf92ff669e0558c68fbc2177eb22 M srcSo to confirm this I built each commit.
Commit https://github.com/libretro/Craft/commit/6afd540ac19ec29b48ecf1997136d5a31ab7fd1e causes the issue obviously. Commit https://github.com/libretro/Craft/commit/28ce0e17b37181396caa6b7b0c54c792ce65f296 does not obviously cause the issue, but will still cause it if the right stick is moved left, but then can be stopped again if moved in another direction.
So I tried to git bisect again.
$ git bisect bad
a37a4147c1b378ab7d9006faff0ed3602f31a9b4 is the first bad commit
commit a37a4147c1b378ab7d9006faff0ed3602f31a9b4
Author: rz5 <razevok@gmail.com>
Date: Fri Mar 11 01:44:27 2016 +0000
Implemented analog controls for movement and aim.
:040000 040000 ab6928fc40a0eed8d109731a1130ed2109589402 7b4ea68989c5bb1f8d0fb8b76ea21b1532b24635 M srcAnd tried each commit manually again.
Commit https://github.com/libretro/Craft/commit/a37a4147c1b378ab7d9006faff0ed3602f31a9b4 introduced both the issue and the ability to aim with the right control stick. This means the aiming implementation has not been working quite right from the start. Commit https://github.com/libretro/Craft/commit/2b781e7946a12c61ee2ec075a12db242cfa348be does not cause the issue, but of course it lacks the functionality to aim with the right stick altogether.
Another issue is that both of the above commits are in the midst of when Craft-libretro was in an extremely broken state where no textures rendered and all that was visible was a vast blue nothing and some empty boxes.
So once more I tried to git bisect it.
$ git bisect good
46128bd93846ef81321db2426e9f1ac783701b6a is the first bad commit
commit 46128bd93846ef81321db2426e9f1ac783701b6a
Author: twinaphex <libretro@gmail.com>
Date: Fri Mar 11 13:02:21 2016 +0100
Fix desktop GL
:040000 040000 eb4494355f7c5fadabd1439e1104d031170af3f9 a426a858fb25055649750939a64134be76113c4e M srcCommit https://github.com/libretro/Craft/commit/46128bd93846ef81321db2426e9f1ac783701b6a is where the blue screen was fixed. Commit https://github.com/libretro/Craft/commit/0d47b397b3693592711ab64fccd99e8a7c3ba38c causes a new black screen + crosshair. Commit https://github.com/libretro/Craft/commit/4e406e1ffb956b3374ed97b54b2955f35570f4cd causes the familiar blue screen.
rz5
OS:
Slackware64-currentRetroArch-1.3.4-x86_64-6_SBoCraft-libretro-2aff567_2016.06.23_master-x86_64-1_gitWith some gamepads plugged in the character won't stop moving even if nothing is being pressed on the keyboard or gamepad, both movement and view. This will stop and start as soon as the gamepad is removed or plugged in and will not happen with only the keyboard. One idea is that any gamepads with more than a d-pad will do it?
Causes issues: https://github.com/libretro/retroarch-joypad-autoconfig/blob/master/udev/Logic3%20Controller.cfg https://github.com/libretro/retroarch-joypad-autoconfig/blob/master/udev/Sony-PlayStation3-DualShock3-Controller-USB.cfg
No issues: https://github.com/libretro/retroarch-joypad-autoconfig/blob/master/udev/Smartjoy%20Family%20Super%20Smartjoy%202.cfg https://github.com/libretro/retroarch-joypad-autoconfig/blob/master/udev/HORI%20CO.%2CLTD.%20REAL%20ARCADE%20PRO.3.cfg