search

libretro / FBNeo

FBNeo - We are Team FBNeo.
https://neo-source.com
Other
228 stars 136 forks source link

wbml: if hiscore is enabled, the file wbml.hi causes the game to launch with "ROM 1 ERROR" #1045

Closed estefan3112 closed 1 year ago

estefan3112 commented 1 year ago

wbml (Wonder Boy In Monster Land Japan) launches and writes a file wbml.hi, if hiscores are enabled in the Core Options. Upon next start, the game stops with "ROM 1 ERROR". Deleting the file wbml.hi lets the game launch again.

estefan3112 commented 1 year ago

PS: The obvious workaround to disable Highscore support in game-specific core options works fine.

barbudreadmon commented 1 year ago

Oops, sorry for the late answer, i didn't notice your report. I'll take a look at this soon.

Btw, i recommend using upstream repo whenever you report an issue, it's easier to have everything centralized there, and more devs check it.

barbudreadmon commented 1 year ago

I think this might be some kind of typo in hiscore.dat, the following line seems suspicious as 0x072f is a rom address and not a ram address (rom being read-only memory, it can't store hiscores) : https://github.com/libretro/FBNeo/blob/6d220068a229a75077d5ca106de85c1e7667776b/metadata/hiscore.dat#L15474

Could you check if hiscores for this game persist properly after removing that line and deleting wbml.hi again ?

estefan3112 commented 1 year ago

Confirmed! ROM error gone after deleting this single line. Still need to check whether hiscores work now... EDIT: Works in the wbml root set! So it's save to close, many thanks!

Question: I posted this issue here because hiscore.dat is provided in this repo. But if it is more convenient, I of course can post it upstream. Again, many thanks!

estefan3112 commented 1 year ago

Add-on: I am not firm enough in Github to create a pull request, otherwise I would do so, apologies :).

barbudreadmon commented 1 year ago

because hiscore.dat is provided in this repo

This is just a file the retropie people asked me to mirror from https://highscore.mameworld.info/ for the sake of convenience. You'd be using exactly the same file if you were running our standalone emulator.

barbudreadmon commented 1 year ago

I'll reopen as a reminder that i need to report this to hiscore.dat's author

estefan3112 commented 1 year ago

I wrote an e-Mail as offered on the website, and I pointed to this issue here with a direct link.