Closed RogueScholar closed 2 months ago
grant2258
commented
2 months ago ../../burner/libretro/libretro.cpp:1220:24: error: format not a string literal and no format arguments [-Werror=format-security]
1220 | sprintf(text_missing_files, RETRO_ERROR_MESSAGES_00);
sprintf(text_missing_files,"%s", RETRO_ERROR_MESSAGES_00);
should fix it or just set the flags to not treat -Werror=format-security as errors.
Its also matches up with you bisect #1081
barbudreadmon
commented
2 months ago That line used to be like this before that PR :
https://github.com/libretro/FBNeo/blob/634d207adade213bbe83684be2a183d158f56e52/src/burner/libretro/libretro.cpp#L1015
Wouldn't that format not a string literal and no format arguments [-Werror=format-security] warning already apply ?
I just pushed that fix but let's flag @taoenwen about this in case there are still issues.
RogueScholar
commented
2 months ago @grant2258 and @barbudreadmon, it's obvious a simple "Duh…" is insufficient here. As a token of gratitude for getting things back on track and not taking any cheap shots at me or my ability to simple read what's in front of me, you both get to be Papa Sylvester, and I'll be "Junior."
I swear that (on most days), I know how to approach that error. I bit off a little more than I could chew lately with some home repairs and days off have been scarce… You get the idea. That said, thank you ever so much for taking the necessary action to make this go away, and the fact that I didn't have to so much as refresh a patch has me on the verge of tears, LOL.
May the Great Compiler in the Sky bless you and keep you, all the days of your life. 👏🏻
libretro-fbneo Debian package for Launchpad Testing PPA currently FTBFS
I've been meaning to get this filed for two weeks, but just never had the time. As stated in the title, the Launchpad PPA builds have been failing for this core on all architectures for over a month now (last successful builds occurred on the morning of 2024-06-02), though I believe the specific errors changed right around two weeks ago. I've copied the current errors below from last night's build log.
Initial observations
This doesn't look like a configuration/packaging error to me, though we have to follow the build hardening policies for the Debian/Ubuntu package archives, plus we've had to add some extra build flags to adapt to the limited memory of the build farm VMs. Which is to say that these are not garden variety "out of the box" compilations and you're likely to see some unfamiliar build flags below. This had always been a problematic core to package so I invested some time back in April into tweaking the build parallelism and some of the other knobs we can twist on Launchpad and was so pleased to get to a point that packages were once again being produced, and this setback has been like a gut punch having taken place so soon after everything was working like gangbusters again.
Analysis of potential causes
A quick Git bisect points to https://github.com/libretro/FBNeo/commit/7f5e365a6b5c89a773163e18ee17410639eb86c9 and #1081, which does seem to coincide with when it seemed to me that the error message changed. Sadly I didn't have time to examine the logs more closely from the builds around the point that they first started failing, and those logs have already been purged. A good central nexus for updated information about the PPA builds for this particular core is the source code package recipe which always shows the status of the most recent builds for all architectures. All of the deviations in the build environment will spring from the Debian packaging files themselves, which are maintained in a separate Git repository on Launchpad.
Build log
Excerpt of log from failed x86_64 (amd64) build on 2024-07-06 (click to expand)
```console buildd:~ $ g++ -c -o../../burner/libretro/libretro.o ../../burner/libretro/libretro.cpp -g -mno-omit-leaf-frame-pointer -ffile-prefix-map=/<