Open 5schatten opened 6 years ago
I have the same issue. Using -DUSE_EGL=OFF
as a workaround doesn't work.
Naive workaround :
diff --git a/Source/Core/Common/GL/GLInterface/EGL.cpp b/Source/Core/Common/GL/GLInterface/EGL.cpp
index cb767bd2a..8edbc9150 100644
--- a/Source/Core/Common/GL/GLInterface/EGL.cpp
+++ b/Source/Core/Common/GL/GLInterface/EGL.cpp
@@ -48,7 +48,7 @@ void cInterfaceEGL::DetectMode()
{
if (s_opengl_mode != GLInterfaceMode::MODE_DETECT)
return;
- bool preferGLES = Config::Get(Config::GFX_PREFER_GLES);
+ bool preferGLES = false;
EGLint num_configs;
bool supportsGL = false, supportsGLES2 = false, supportsGLES3 = false;
As a side note, it looks like this is an error in Ishiiruka itself and not the libretro port. You may want to escalate this issue.
Tried to build the latest version (https://github.com/libretro/Ishiiruka/commit/da73ee50112610757cb8ec55d58e36d3c70833a2) without the patch but still got this error:
/home/supervisedthinking/le90-rr/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.0-devel/libretro-ishiiruka-da73ee5/Source/Core/Common/GL/GLInterface/EGL.cpp: In member function 'void cInterfaceEGL::DetectMode()':
/home/supervisedthinking/le90-rr/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.0-devel/libretro-ishiiruka-da73ee5/Source/Core/Common/GL/GLInterface/EGL.cpp:51:41: error: 'GFX_PREFER_GLES' is not a member of 'Config'
bool preferGLES = Config::Get(Config::GFX_PREFER_GLES);
^~~~~~~
/home/supervisedthinking/le90-rr/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.0-devel/libretro-ishiiruka-da73ee5/Source/Core/Common/GL/GLInterface/EGL.cpp:51:41: note: suggested alternative: 'GFX_FREE_LOOK'
bool preferGLES = Config::Get(Config::GFX_PREFER_GLES);
^~~~~~~
GFX_FREE_LOOK
make[2]: [Source/Core/Common/CMakeFiles/common.dir/build.make:700: Source/Core/Common/CMakeFiles/common.dir/GL/GLInterface/EGL.cpp.o] Error 1
make[2]: Waiting for unfinished jobs....
make[1]: [CMakeFiles/Makefile2:1257: Source/Core/Common/CMakeFiles/common.dir/all] Error 2
make[1]: Waiting for unfinished jobs....
So I guess vanilla needs to fix that.
should be fixed in the latest ishiiruka version
@twinaphex could you pull upstream code or at least https://github.com/Tinob/Ishiiruka/commit/f681b6aa3241e6f577f881b1947d6bb62bbdf39a to see if it fixes the build? :-)
I applied Tinob@f681b6a as patch locally and can confirm that fixes the build.
Hi there.
What do you guys want me to do here? Pull the latest upstream code from usptream, does that fix it on its own? If so, I could do that.
I think the patch is from upstream, yes
Well I'm able to build libretro-dolphin but the libretro-Ishiiruka core fails:
/home/supervisedthinking/le90-rr/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.0-devel/libretro-Ishiiruka-617ba3d/Source/Core/Common/GL/GLInterface/EGL.cpp: In member function 'void cInterfaceEGL::DetectMode()': /home/supervisedthinking/le90-rr/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.0-devel/libretro-Ishiiruka-617ba3d/Source/Core/Common/GL/GLInterface/EGL.cpp:51:41: error: 'GFX_PREFER_GLES' is not a member of 'Config' bool preferGLES = Config::Get(Config::GFX_PREFER_GLES); ^~~~~~~~~~~~~~~ /home/supervisedthinking/le90-rr/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.0-devel/libretro-Ishiiruka-617ba3d/Source/Core/Common/GL/GLInterface/EGL.cpp:51:41: note: suggested alternative: 'GFX_FREE_LOOK' bool preferGLES = Config::Get(Config::GFX_PREFER_GLES); ^~~~~~~~~~~~~~~ GFX_FREE_LOOK make[2]: *** [Source/Core/Common/CMakeFiles/common.dir/build.make:700: Source/Core/Common/CMakeFiles/common.dir/GL/GLInterface/EGL.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [CMakeFiles/Makefile2:1257: Source/Core/Common/CMakeFiles/common.dir/all] Error 2 make: *** [Makefile:152: all] Error 2
https://pastebin.com/mWXubwzV