search

libretro / LRPS2

GNU General Public License v2.0
159 stars 47 forks source link

Fix Bios #154

Closed liberodark closed 2 years ago

liberodark commented 2 years ago

Hi,

Set hardcorded bios is not good idea is better to set "" for let pcsx2 check bios where is defined.

Best Regards

SeventySixx commented 2 years ago

I'm not sure if I understand what this fix wants to achieve.

Do the wxDir::GetAllFiles search recursively also in subfolders?

Because with the hardcoded bios sub-path, users are forced to put bios files in < retroarch system >/pcsx2/bios folder, and we are sure that bios files are only in that folder. Also for supporting user problems, this is better.

If wxDir::GetAllFiles searches recursively, the user can put bios files in a random location inside the < retroarch system > path, and this could work (with the risk users will mess with locations of their bios files). But this will break the implementation of #153 , because it will be difficult to rebuild the path of the file in memory, it will be necessary go to searching for the file location.

@twinaphex what do you think about it?

bslenul commented 2 years ago

I don't think that would be a good idea to split the locations of the core files/folders. I mean it uses system/pcsx2/ for other stuff like cheats, why would we want to split that with system/ for the BIOS?

Also wouldn't that increase the startup time if the core has to scan every files in system/ + in every subfolders?

yxmline commented 2 years ago

bios files are placed in a separate folder without confusion

inactive123 commented 2 years ago

Hi @liberodark ,

can this serve as a substitute for your PR?

https://github.com/libretro/pcsx2/pull/155

It already got merged.