search

libretro / LRPS2

GNU General Public License v2.0
159 stars 47 forks source link

Fix GameDB load error (indentation) #160

Closed Sanaki closed 2 years ago

Sanaki commented 2 years ago

Apparently tabs break the GameDB, but replacing it with spaces fixed it fine.

inactive123 commented 2 years ago

Hi @Sanaki , can you let me know what this actually fixed?

I ask because Xbox people are telling me this commit actually breaks things for them.

inactive123 commented 2 years ago

@SeventySixx @covey-j Do you guys know maybe what might be up here?

Gamr13 commented 2 years ago

It seems this commit broke PCSX2 games on Xbox again.

GABO1423 on Discord built the core yesterday afternoon without this fix and games started working again.

It seems to me like all these games that are crashing on Xbox have game fixes, like Klonoa 2.

The build from yesterday works great, but is noticeably lacking the game fixes which I noticed when testing Klonoa 2 today.

Sanaki commented 2 years ago

This fixed the following error.

[libretro ERROR] [GameDB] Error occured when initializing GameDB: yaml-cpp: error at line 35324, column 1: illegal tab when looking for indentation
[libretro ERROR] [GameDB] Database could not be loaded successfully

Based on Gamr13's comment, it sounds like the GameDB itself is breaking the xbox build, so fixing the GameDB caused the issue to appear.

GABO1423 commented 2 years ago

I can confirm that this commit caused some games on PCSX2 to crash after the PlayStation 2 bootlogo, games with this behavior include Gran Turismo 4, Crash Twinsanity, Klonoa 2, and Burnout 3. While making a test build of PR #161, I decided to manually revert this PR and the games listed above worked correctly.

inactive123 commented 2 years ago

I guess due to the internal game database no longer working, suddenly all these games worked because the pnach patches are not being applied. So technically it seems like this PR is not 'wrong' or 'buggy' but it points to an underlying issue on Xbox when we are applying pnach patches from the internal database.

@GABO1423 We might have to start doing some logging in PCSX2 debug builds and run them on Xbox or PC UWP to see if we can figure out why all of a sudden it has trouble applying pnach patches for games like this.

GABO1423 commented 2 years ago

@twinaphex I'll open a new issue then so we can discuss this problem on a more appropriate location.