search

libretro / LRPS2

GNU General Public License v2.0
172 stars 49 forks source link

Revert Commit 88f8126 #194

Closed Gamr13 closed 2 years ago

Gamr13 commented 2 years ago

Instead of leaving RetroArch open with a zombie process rendering it useless until closed, this PR reverts that change so RetroArch will crash when Close Content is pressed, this is a time save and avoids confusion for users.

inactive123 commented 2 years ago

I disagree with this. The issue should be fundamentally fixed, this literally solves nothing.

@jdgleaver told me that he'd be looking at this core after the holidays to see if we can arrive at a proper solution. Closing this for now.

Gamr13 commented 2 years ago

Good to know, I decided to create a PR for this for the meantime. Too many questions asking about the black screen hang got annoying, so this was meant as a temporary band-aid solution.

covey-j commented 2 years ago

@Gamr13 You might want to take a look at the #83 thread (this PR makes the same change as that one, which is to say it reverts the changes of #56). IIRC, even with this change you still run into the zombie process bug in certain games (e.g. Tekken Tag Tournament) or if you use MTVU.

Apart from that, crashing on Close Content makes it difficult to change any of the core options that require content restart, which was the reason I opened #56 as a temporary workaround for the crashes until a proper fix is found.