search

libretro / LRPS2

GNU General Public License v2.0
159 stars 47 forks source link

dx11 renderer broken for GoW2 #219

Closed ckeisc closed 2 years ago

ckeisc commented 2 years ago

The latest pcsx2 core (02a24a18) when running with dx11 video driver on retroarch (and dx11 renderer on pcsx2 core) is showing graphics glitch that is not showing on OpenGL or older version of the dx11 core. It is very pronounced everywhere in God of War 2. Enemies or various meshes would clip through walls (see screenshots). I have a much older build from late last year without the problem (3ef2a36b0). This is very visible on Xbox UWP since it can only use dx11 renderer but also repros on Windows desktop when using dx11.

This is what it looks like under glcore driver God of War II (USA)-220613-192640

This is what it looks like under dx11 driver RetroArch pcsx2 (alpha) 02a24a18 6_13_2022 7_31_44 PM

ckeisc commented 2 years ago

@LibretroAdmin - I checked an earlier build 52b74b77 released as part of 1.10.3 on 5/2 that is free of this issue. That makes this commit 7d24934921393aeb4cdb5454e7d53c5fc0b8e2e2 from 5/16 quite a suspect for the regression.

TheRhysWyrill commented 2 years ago

This is something i've been looking into myself recently and it seems that both commit 8893363 and 7d24934 cause the graphics/visual effects of some games to break completely, i've actually managed to build the pcsx2 core while omitting any of the changes made to GSDevice11.cpp and GSTexture11.cpp and it appears to working as intended without any of the graphical issues.

TheRhysWyrill commented 2 years ago

@ckeisc You might want to double check whether this is still an issue with the latest pcsx2 core, this commit should have fixed the graphical issues 180c1b9.

ckeisc commented 2 years ago

Fixed now