search

libretro / LRPS2

GNU General Public License v2.0
172 stars 49 forks source link

"Preload frame data" option missing from RA interface, works if toggled in source code #248

Open ghost opened 1 year ago

ghost commented 1 year ago

https://github.com/libretro/LRPS2/blob/main/plugins/GS/Renderers/HW/GSTextureCache.cpp

If you flip the m_preload_frame bool to true here, it enables it and works as expected.

King's Field 4 is broken without this setting or software renderer. Pic related.

Without this setting or SW renderer: King's Field - The Ancient City (USA)-221230-174113

With this setting (or hypothetical SW renderer) King's Field - The Ancient City (USA)-221230-174024

LibretroAdmin commented 1 year ago

Thanks for making me aware of this.

LibretroAdmin commented 1 year ago

Kind of a hack so far but better than nothing -

https://github.com/libretro/LRPS2/commit/31bde264569a67807ba8fb6d5b99b96c15ba92c0

You need to restart content for the changes to take effect. So switch it to OFF, content close, then start game again to see it take effect. It can't be toggled on the fly.

Also, I want to start doing what mainline does and set the recommended values for these userhacks per-game inside the yaml database file, and then auto applying them so the user doesn't have to manually fiddle knobs like this.