libretro / Lakka-LibreELEC

Lakka is a lightweight Linux distribution that transforms a small computer into a full blown game console.
https://www.lakka.tv
1.76k stars 289 forks source link

Samba: prevent new files being marked as executable #1886

Closed synthic closed 1 year ago

synthic commented 1 year ago

This pull request updates the default SMB configuration file to set the permissions for new files to 644, from the original default of 744. I am submitting this because it doesn't make sense for ROM files copied over the network to be marked as executable and it can be confusing to see lots of highlighted files when listing them in the terminal. 644 also matches the current umask for new files created on the system directly. There are no compatibility issues with other OS to worry about either as DOS permissions are stored in extended attributes by modern versions of Samba.

Lakka:~ # umask
0022
Lakka:~ # touch test
Lakka:~ # ls -l test
-rw-r--r--    1 root     root             0 Sep 29 23:34 test