libretro / Lakka-LibreELEC

Lakka is a lightweight Linux distribution that transforms a small computer into a full blown game console.
https://www.lakka.tv
1.7k stars 289 forks source link

When building from source for s905 you get a prompt on kconfig #74

Closed shantigilbert closed 7 years ago

shantigilbert commented 7 years ago

When trying to build from the latest source (RC2) for the S905 project I get this:

scripts/kconfig/menu.c:548:19: note: ‘jump’ was declared here
  struct jump_key *jump;
                   ^
  HOSTLD  scripts/kconfig/conf
scripts/kconfig/conf --oldconfig Kconfig
drivers/amlogic/wifi/bcmdhd/Kconfig:50:warning: defaults for choice values not supported
*
* Restart config...
*
*
* I2C Hardware Bus support
*
Amlogic I2C Driver (I2C_AML) [Y/n/?] y
Amlogic I2C Slave Driver (I2C_SLAVE_AML) [N/y/?] n
Amlogic software I2C Driver (I2C_SW_AML) [N/y/?] n
BCM2079X_I2C support (BCM2079X_I2C) [N/y/?] (NEW)

Whatever you choose it appears to builds fine, but this didn't happen before commit 76ebcb I think. edit: changing this in linux.aarch64.conf:

#
# I2C Hardware Bus support
#
CONFIG_I2C_AML=y
# CONFIG_I2C_SLAVE_AML is not set
# CONFIG_I2C_SW_AML is not set
CONFIG_AML_PWM=y
CONFIG_GX_PWM=y

to this

#
# I2C Hardware Bus support
#
CONFIG_I2C_AML=y
# CONFIG_I2C_SLAVE_AML is not set
# CONFIG_I2C_SW_AML is not set
# CONFIG_BCM2079X_I2C is not set
CONFIG_AML_PWM=y
CONFIG_GX_PWM=y

fixes the issue

shantigilbert commented 7 years ago

Fixed with commit https://github.com/lakkatv/Lakka-LibreELEC/commit/c56762a21b4602118df8b6b8d2c9dd45313d8e19