search

libretro / Mesen

Mesen is a cross-platform (Windows & Linux) NES/Famicom emulator built in C++
https://www.mesen.ca
GNU General Public License v3.0
15 stars 20 forks source link

Can't load HD Packs when loading a rom from an archive #9

Closed Monyet28 closed 3 years ago

Monyet28 commented 3 years ago

The behaviour of the RA core is different to the standalone version. If you load a rom that is within an archive, even if you name the HD pack the same as the filename.zip or the extracted rom.nes, it will not load the HD pack. It will also not load HD Packs that are zipped, only loading them when they are extracted.

Sanaki commented 3 years ago

Can't reproduce. All my games are within 7z archives and they load HD packs fine.

Monyet28 commented 3 years ago

Well then, Any ideas? Because that's the behaviour I'm seeing. If I run rom.nes I get textures, If I run Rom.7z I get no textures. I thought maybe my path length could be a culprit which is \Launchbox\Games\Nintendo Entertainment System\rom.7z and Retroarch is stored in \Launchbox\Emulators\Retroarch\

Sanaki commented 3 years ago

Apologies, I had been testing a build and forgot to reset it. I think you're right and we've stumbled onto a regression. I'll bisect and see what I can find.

Monyet28 commented 3 years ago

No worries, the only other variable I can give you is that I dropped the latest RA version over the top of the old one so it's not a fresh install. I found another branch of Mesen run by a MkWong98. Is this branch the one that gets put out as a core or is MkWong98's? I'm new to this so just asking.

Sanaki commented 3 years ago

This is the correct fork for the libretro core.

The regression occurred in libretro/retroarch@334a43a7c5b072d468b8cb4d6b4d1737795d12e3. Since it's a frontend change but could be a core behavior issue, I'm not really sure which end it needs to be fixed on. Perhaps @jdgleaver would know better.

In the meantime, you can either run 1.9.3 stable or the May 19th nightly to retain archived HD pack functionality until it's sorted on one end or the other.

Monyet28 commented 3 years ago

Cool, will do. Thanks.

jdgleaver commented 3 years ago

Please see my comment here: https://github.com/libretro/RetroArch/pull/12421#issuecomment-850832775

This is a core issue. I will have a look at fixing it once the API extension mentioned in the comment is complete (I need another day or so for this...)

Sanaki commented 3 years ago

Oof, yeah, I didn't go so far as reading comments there. Definitely would prefer not to require need_fullpath. Thanks for the info.

jdgleaver commented 3 years ago

There we go - this should solve the issue: #10

Sanaki commented 3 years ago

Works beautifully, thank you.

Monyet28 commented 3 years ago

Cheers for that!