Merge upstream, rumble support, minor improvements

libretro / OpenLara

Classic Tomb Raider open-source engine

BSD 2-Clause "Simplified" License

12 stars 18 forks source link

Merge upstream, rumble support, minor improvements #5

Closed derpeg closed 5 years ago

derpeg commented 5 years ago

Merge XProger/OpenLara
Hook up rumble support
Fix handling of start button (to accommodate upstream changes to local multiplayer)
Provide input descriptions for Player 2.

Tatsuya79 commented 5 years ago

Hi, nice job updating but I have an issue with the rumble feature. Both gamepads vibrates when starting the core or just getting into the in-game menu by pressing select. Turning it off for both players didn't fix that.

win7 x64

derpeg commented 5 years ago

Hi. Could you provide some more info so I can reproduce?

Tested so far: Loading Core+Content from GUI: No unexpected rumble. Loading Core+Content from CLI: No unexpected rumble. Entering RetroArch menu (Start+Select): No expected rumble.

Tatsuya79 commented 5 years ago

Not in RA menu, it happens in the game.

Loading "Tomb Raider 1\DATA\LEVEL1.PHD" with the OpenLara core = both xinput xbone gamepad rumbles when the game starts. Then pressing select in-game = both rumble again. Same when leaving the menu with select.

derpeg commented 5 years ago

Ah. Gotcha. I'll look into it!

EDIT: Yeah, stupid mistake on my side. I've fixed it in my fork and will file a PR soonish. Thanks a lot for reporting!