search

libretro / QuickNES_Core

The QuickNES core library, originally by Shay Green, heavily modified
GNU General Public License v2.0
22 stars 35 forks source link

No PAL option/support? #52

Open maddin1502 opened 6 years ago

maddin1502 commented 6 years ago

I can't run PAL roms with correct speed, there is no region option available. Or am I wrong?

I adjusted some code and tried to get PAL working: `unsigned retro_get_region(void)

  1. /libretro/libretro.cpp (no recognized effect) unsigned retro_get_region(void) {

    return RETRO_REGION_NTSC;

    return RETRO_REGION_PAL; }

  2. /nes_emu/Nes_Emu.h (video speed is correct with this setting) // Number of frames generated per second

    enum { frame_rate = 60 };

    enum { frame_rate = 50 };

  3. /nes_emu/Nes_Apu.cpp (no recognized effect) Nes_Apu::Nes_Apu() : square1( &square_synth ), square2( &square_synth ) { ...

    reset( false);

    reset( true ); }

Option 2 resolves video speed. But now the sound is wrong.... speed is OK, pitch is too low How can I do it right?

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/58087591-no-pal-option-support?utm_campaign=plugin&utm_content=tracker%2F1029493&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1029493&utm_medium=issues&utm_source=github).
ghost commented 6 years ago

maybe use other full (or fuller) featured NES cores, unless you are suggesting you want to work on adding missing stuff...

maddin1502 commented 6 years ago

it is not really missing. fps are hardcoded, so changing 60 to 50 works well for video. I don't know how to solve the sound/pitch problem. there are some calculation done in code for sound but i can't find the right one or I just can not understand these. it's too complex without deeper knowledge.

i want to use quicknes because it's the emulator with best performance. others are stuttering