At present, the core causes RetroArch to segfault if the 'show overscan' options are toggled from off to on while using a CPU filter. This is because the maximum framebuffer dimensions are always set to the current screen size, and when the current screen size increases (i.e. show overscan) we only get a call to RETRO_ENVIRONMENT_SET_GEOMETRY, not RETRO_ENVIRONMENT_SET_SYSTEM_AV_INFO. The CPU filter video buffer therefore ends up being too small, and we get an access violation. (To be fair, this looks like a simple typo... and ironically, I just noticed I made a typo in the commit message...)
This pull request sets the max width/height correctly, and fixes the issue.
At present, the core causes RetroArch to segfault if the 'show overscan' options are toggled from off to on while using a CPU filter. This is because the maximum framebuffer dimensions are always set to the current screen size, and when the current screen size increases (i.e. show overscan) we only get a call to RETRO_ENVIRONMENT_SET_GEOMETRY, not RETRO_ENVIRONMENT_SET_SYSTEM_AV_INFO. The CPU filter video buffer therefore ends up being too small, and we get an access violation. (To be fair, this looks like a simple typo... and ironically, I just noticed I made a typo in the commit message...)
This pull request sets the max width/height correctly, and fixes the issue.