libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
9.79k stars 1.78k forks source link

Bad screenshot aspect ratio under specific conditions #10176

Open ner00 opened 4 years ago

ner00 commented 4 years ago

Description

A screenshot taken of off the title screen of Saturn's game Dead or Alive (Japan), emulated through Beetle Saturn, will have a bad aspect ratio if RA's video driver is set as d3d10/d3d11/d3d12

Expected behavior

The aspect ratio scale should be respected, regardless of the video driver. When using gl video driver this issue does not happen.

Actual behavior

The titlescreen ratiot cannot possibly be correct, it squishes the image (width issue). When the video driver is set to d3d10/11/12, I will get different resolutions and aspect ratios at different places; specific examples:

  1. Title screen: 352x480 (this one is very off base, this is close to 8:11 AR)
  2. Character selection: 352x240
  3. Fighting arena: 704x480

RA's settings have a AR scale of 4:3, none of those screenshots seem to be at that ratio, but 2 and 3 aside, 1 (the title screen) is not right in any way.

Steps to reproduce the bug

  1. Run game
  2. Change video driver to d3d10/11/12
  3. Take screenshot (at title screen in particular)

Bisect Results

I have no clue, all I can say is that this does not happen when using Kronos emulator; this isn't to say that the issue is the emulator, but there certainly is a causality between the two. As far as I can tell, Kronos forces the video driver back to gl or glcore anyway, but not Beetle Saturn.

I have also compared this using the same method with another title, Virtua Fighter 2 (USA); in this case the AR is closer to what would be expected, emphasis on the title screen:

  1. Title screen: 704x480
  2. Character selection: 352x240
  3. Fighting arena: 704x480

Version/Commit

Environment information

rtomasa commented 7 months ago

This is most probably due to this issue: https://github.com/libretro/beetle-saturn-libretro/issues/27