search

libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.05k stars 1.81k forks source link

Scan MAME(219) merged romset #10395

Open guoyunhe opened 4 years ago

guoyunhe commented 4 years ago

First and foremost consider this:

Description

I downloaded mame 219 merged romset but cannot scan it into playlist.

Expected behavior

Scan cannot add any entries into playlist.

Actual behavior

Scan should add entries into playlist.

Steps to reproduce the bug

  1. Download mame 219 merged romset
  2. Scan the directory
  3. Check if MAME playlist is created with roms.

Bisect Results

Version/Commit

You can find this information under Information/System Information

Environment information

i30817 commented 4 years ago

Use the manual scanner, it has a option to use a MAME type dat as input and another option to filter out romfiles that aren't in the dat.

In fact, it also works for other systems, as long as the dat has the 'shape' of a MAME dat (which, granted, is unusual unless you take matters into your own hands with a XSL transformation or are using mame dats for the system). For mame, you can use merged, split or non-merged with this, as long as you have a mechanism to filter out devices and bios (this exists already on MAME dats on the form of 'game->is_bios' and 'game->is_runnable' xml properties(iirc). You can even create 'genre' dats.

Also please don't link to mame sets, congress archive exception or not, considering the government of the USA at the moment.

Zoltan45 commented 4 years ago

I have been through so much lately, do not take this as gospel, but I do believe you have to unmerge your ROMset. Retroarch is built on 1 game per zip approach.

guoyunhe commented 4 years ago

According to this PR #5663 , it should be able to scan members of the rom. And we do have member-mame data file: https://github.com/libretro/libretro-database/blob/master/metadat/mame-member/MAME.dat

i30817 commented 4 years ago

Ah. I misread things. The manual scanner doesn't help with merged romsets, just split or non-merged, because it uses external filenames to match. Sorry about that.