search

libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.17k stars 1.82k forks source link

Cursor Manager Doesn't Function and Never Has, Can It Be Removed? #10682

Open im4potato opened 4 years ago

im4potato commented 4 years ago

Description

The Cursor Manager and its related functionality has never been implemented. This feature was supposed to allow custom database queries to the ROM database.

I'd like to see one of two things happen:

  1. The feature/code is removed entirely, we shouldn't keep a bunch of dead code around for a feature that nobody plans to work on.
  2. Hide the Main Menu > Information > Cursor Manager and Settings > Directory > Cursor menu items, they don't work and will only confuse users.

I would prefer to remove the code entirely, I think the less dead code in the codebase the better, but I can understand wanting to simply hide it and keep it around on the off chance someone decides to pick the feature back up (which seems unlikely due to years of inactivity).

I should be able to handle the code removal, but obviously I need some feedback as to which option the main RetroArch developers prefer.

@twinaphex @hizzlekizzle

hizzlekizzle commented 4 years ago

I vote for removal. It's been there for years with ample opportunity to take off but never has.

inactive123 commented 4 years ago

I'd like to still do something with it. All we need is some guy taking the initiative to write some menu code around it.

Sanaki commented 4 years ago

I want to be clear, it does work. It just isn't being used much. A couple of the "template" cursors don't work because they're looking for information that isn't in the rdb. I don't actually have a stance on removal, since I don't use them and I don't know of anyone else who does offhand, but to say they're nonfunctional is simply incorrect. Cursors

im4potato commented 4 years ago

@Sanaki How does the user go about getting these cursors? I see no way within RetroArch to download them.

@twinaphex You're the boss, if you want to keep them that's fine. What do you think about simply hiding the feature for now until it receives more work?

Sanaki commented 4 years ago

There are only a few samples here: https://github.com/libretro/libretro-database/tree/master/cursors I believe the intention is that you generate them yourself. Though I'm sure if someone felt like fleshing out the ones there enough, it could warrant making them downloadable within retroarch.