Open birdybro opened 4 years ago
You might be confusing this with the previous issue I raised with an automatic m3u generator feature request, which we both talked about back then too. :) - This is in regards to the scan directory behavior not being appropriate for the most used core when it comes to multi-disc games.
How much technical knowledge is it to do this? Is it simple data entry for the most part? If it is, then I guess I could start knocking them out.
This doesn't generate a playlist (.lpl) file though. I remember when we chatted about this last in my feature request here previously that the idea was to integrate it.
My issue raised here assumes that the user has already made their own .m3u files, and the scanning of the directory doesn't work as it ought to. I think I will spin off your gist like i had previously planned to since I have gotten slightly more experience messing with code since we last chatted about it, just as a side thing.
Guess i forgot. About 2, it's a scripting problem and a 'enforce contributors contribute files in a specific way' problem.
edit: had a better idea than symlinks in step 7. edit2: read a bit about git and extended attributes wouldn't work but symlinks do.
The idea is simple. Someone contributes a image with listing the game console that applies, and the file(s) with a filename like Xenogears (USA).png - xenogears the game has two discs, but assume the image is the same for now. If they want a particular edition or cd to be different they can be more specific, aka 2 files, 'Xenogears (USA) (Disk 1).png' and 'Xenogears (USA) (Disk 2).png'
Now for the script. Periodically the person updating the thumbnail database runs a script that:
Finally: What about the M3U?. The above 'created' the missing entries on the database, as much as possible. But while you could make RA use Xenogears (USA).m3u
as the standard name and leave it at that, users are crazy, and probably want to rename the M3U (add a abbreviated hack name that isn't upstream but the full hack name is, etc). Make the scanner assign the image of the first entry in the M3U for M3U's is my personal preference to work around these issues. This is a separate modification to the script above though.
edited the algorithm above to hopefully be a bit more clear (edit: again). Anyway, i find it doable, certainly in python or whatever libretro database uses, and with a standalone rdb search tool that retroarch can compile. It would balloon the size of the repository though i'm not sure they care. Users with full sets would probably appreciate if it was possible for the RA thumbnail downloader to use symbolic links for these - for multidisks, and multifloppies, since some floppy games can go to 10 or more and 3-5 is not unusual.
It's better to encourage users to use M3U than make the thumbnails have a complicated symlink system thats not portable, and push cores to support M3U to make users save on thumbnail bandwidth. A project like Ludo could even enforce that the only format their playlists support is M3U and if they could have core support, profit by having a simpler UI and experience as well as a less huge thumbnail folder.
But who knows, maybe some github guy make something simpler like a github plugin that for commits for libretro-database and runs a dialog 'Are you sure you don't also want to add this list of files as aliases for your 'Game.png'' (the list being given by those autocorrect word algorithms) and copies into filename check the committed image.
Btw @birdybro , i remember @jdgleaver implementing something like the filtering for files inside m3u scanned that you mention doesn't work? Am i just imagining it @jdgleaver?
Yes, if you scan an M3U file with the manual scanner, it will automatically exclude any files that are referenced inside. Also, if you clean a playlist (Manage Playlists > Clean Playlist
), it will remove any individually-listed items that are duplicated inside M3Us.
I must have been doing something wrong with the manual scanner, I have confirmed that it works, but that doesn't address the other issues. Can't this same behavior from the manual scanner be imported into the automatic scanner?
As far as .m3u generation, I found a great tool for this which I believe works cross-platform, maybe the method could be implemented.
https://github.com/tralph3/Cue-Maker
Or maybe this person would be interested in contributing to retroarch with the m3u generation python script they made @tralph3
I actually made the script thinking about retroarch, but I don't think retroarch should be in charge of making m3u or cue files. I do want it to detect the m3u automatically and ignore the cue files inside it so I have a single entry with multi disc games (this is currently possible, but I have to manually remove the cues and add the m3u with the desktop app).
Description
Multiple problems with M3U files in the user interface as of version 19.0 (and as long as beetle cores have required m3u for multi-disc on-the-fly changing). M3U files are a requirement for using beetle cores that are for CD games with multi-disc support. Here's the problems that need to be addressed as it's very unintuitive to use M3U's but still required:
Expected behavior
I expect to "scan directory" the PSX directory and have my .m3u supported games have a thumbnail, game information from teh database, and my cue-only games to be scanned in like before, with the cue's for m3u-supported games being excluded from the list.
Actual behavior
Scan directory adds only cue files from the psx directory, ignores m3u, and if you manual scan the directory for .m3u, then it still doesn't use the games database and therefore gets no game information or thumbnails for the m3u entries. If you scan manually for m3u only, you are excluding cue, if you scan manually for cue, you miss m3u, and if you scan manually for both, you have excess cue entries from .m3u enabled games.
Steps to reproduce the bug
Import --> scan directory --> a psx folder with a mixed set of m3u-using games and cue-using games --> look at the psx playlist and see no m3u files --> manual scan for m3u --> update thumbnails --> m3u games are now added, but no game information and no thumbnails and redundant cue files for each disc have to be manually removed
Version/Commit
You can find this information under Information/System Information
Environment information