libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
9.87k stars 1.78k forks source link

RetroArch Web Player contributions #12961

Open enten opened 2 years ago

enten commented 2 years ago

Are contributions for the RetroArch Web Player possibles?

As there is no contribution guide for the web player, I would like to have direct feedbacks from contributors.

I think that the emscripten compilation is a great idea. I suppose that it requires specific developments.

Furthermore, I think that the web player is a good showcase and we can simplify the user experience.

How about wrapping the web player logic into webapp to manage core features through web components?

Proof of concept here: https://enten.github.io/retroweb/ (warn: this poc has no error handling yet).

Thanks for reading.

andres-asm commented 2 years ago

that's pretty cool just send a PR, it will be reviewed and merged if viable

enten commented 2 years ago

@fr500 I think the proof of concept is still in early stages. There are still developments needed before submit a first PR (principally writing of unit tests and documentation). I sent you an invitation if you want to check the current state of the prototype in this repo (the repo is currently private but I plan to open it before opening PR). If you check the repo of the prototype, you can see that it's an angular workspace development.

I opened this issue firstly to know if contribution on the webplayer is acceptable and especially to have a feedback about the idea of providing a web client for the libretro webassembly compilation.

As contribution on the webplayer is welcomed, I will continue working on a first beta release based the prototype. That will be the subject of a future contribution.

But I think it should be better to separate the code source of that modern webplayer from the main code source of libretro. How about adding a new repository into libretro github group for that potential modern webplayer (reserved by the libretro working group's acceptance)?

andres-asm commented 2 years ago

hi

Well, that's how things used to work, but honestly I'm no longer a contributor. You should talk to @twinaphex or @jdgleaver

andres-asm commented 2 years ago

@enten you should remove AlttP and SMB, those are copyrighted material and seems wrong

enten commented 2 years ago

@fr500 Thanks for your answers.

You should talk to twinaphex or jdgleaver

I noted. I will notice them when the work is more advanced.

you should remove AlttP and SMB, those are copyrighted material and seems wrong

My bads. I will remove AlttP and SMB soon. It was just for testing (note: I have physical cardbridges of these roms).

Just for information: did you try to run any of AlttP or SMB rom? Did it work?
Normally, the download of AlttP or SMB is provided by ipfs.
I'm asking if a feature to search rom in ipfs network is possible? I mean, technically it's possible. But I think that need a disclamer to remember that it's ok only for user who have a physical copy of the rom.
Do you have any opinions or suggestions about that?

mahoneyt944 commented 2 years ago

Just opened an issue on emscripten. #13118 might be of interest

enten commented 2 years ago

@mahoneyt944 Thanks for information.

I think that issue doesn't affect the version of the web player discussed in this thread.

The main purpose of that web player "fork" is the management of core features through web components.

If you check the demo here, you will see that you can install/play a game or a core engine with few clicks on html components. The web player is display only when a core engine is running.

Indeed, as the key F1 is still configured to open the native web player menu: the bug is reproductible in the fork. But the goal is to avoid using native web player menu by let the web app which wrap the web player do these stuff.

nenge123 commented 2 years ago

do you can make the cores file?

buildbot lost desmume/pcsx cores.


https://github.com/nenge123/mgba-retroarch

the emscripten ,i need some Future