search

libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
9.77k stars 1.77k forks source link

[WIIU] Overlays are always full_screen #13291

Open vaguerant opened 2 years ago

vaguerant commented 2 years ago

Description

Some overlays are intended to only fill the game area, like several of those in https://github.com/libretro/common-overlays/tree/master/effects/scanlines

These overlays behave the same as overlays with overlay0_full_screen = true, filling the entire screen with scanlines rather than just the game image.

Expected behavior

The default setting for overlay0_full_screen is false, so any overlay that either doesn't include this setting or sets it to false should only fill the game area.

Actual behavior

They fill the entire screen.

Steps to reproduce the bug

  1. Set a directory for overlays in the directory settings (Wii U has no default overlay directory).
  2. Download the overlays.
  3. Enable any overlay that is intended to display only over the game image.
  4. Observe that the overlay fills the entire screen.

Bisect Results

I didn't bisect, I don't think anybody really uses overlays on Wii U so it's pretty likely it's just always been this way and nobody noticed.

Version/Commit

Environment information

dre10g commented 11 months ago

I just noticed this on my miyoo mini plus handheld (4:3). According to the wiki, it should default to only apply to the game viewport but it doesn't. I have a crt overlay, but when used with arcade games, eg: double dragon, which has black bars on left right side, those black bars have the filter applied also. Which looks bad. I have tried both removing the overlay0_full_screen line, and editing it to overlay0_full_screen="false" but it does the same thing as overlay0_full_screen="true" in both cases. Example