search

libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.3k stars 1.84k forks source link

(Menu) No default cores for Favorites #13504

Closed erahhal closed 2 years ago

erahhal commented 2 years ago

When adding a game to favorites from a playlist, the default core should referenced, or at least set for the favorite.

RobLoach commented 2 years ago

Last time I tested this, it worked. Could you highlight a step by step list to reproduce?

erahhal commented 2 years ago

Version: 1.9.14 Platform: Windows 10 Path: "e:\retrogames\Retroarch"

  1. Scan roms in "roms" folder
  2. Go to playlist settings, set default core for a particular platform
  3. Launch a game in the playlist. Note that it doesn't ask you to select a core.
  4. Add same game to favorites from the playlist.
  5. Launch game from favorites - it asks you to select a core.
erahhal commented 2 years ago

I've got more specifics for you. This only happens if you've never launched the game. If you set a default core for a playlist, launch the game, then add it to favorites, it works. If you set a default core for the playlist, then directly add the game to favorites, it does not work.

I don't know how things work behind the scenes, but it seems that setting the default core for a playlist should iterate through all the games and set the default core for them as well, and then when a game is added to a playlist that already has a default core, it should be set then as well.