libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.05k stars 1.81k forks source link

[Netplay] systematically freezing on server host creation if quit_on_close_content = "1" #15313

Closed schmurtzm closed 8 months ago

schmurtzm commented 1 year ago

Description

When quit_on_close_content = "1" in retroarch.cfg then Netplay will systematically freeze on server host creation. As Retroarch restart the game when running a Netplay host, this option has a bad effect. This can be hard for users to diagnose this freeze as this option to close Retroarch when closing content is pretty common.

Expected behavior

Net server creation should not freeze whatever the current setting on quit_on_close_content.

Actual behavior

Retroarch is frozen, impossible to go in the menu again.

Steps to reproduce the bug

1 - turn on "quit on close content" : "Settings" -> "User interface" -> "quit on close content" 2 - run a SNES (snes9x2005 plus) or MD (Pico) game (but probably any core / any game will do the same) 3- start a Netplay Host -> retroarch is frozen, impossible to go in the menu again.

Version/Commit

You can find this information under Information/System Information

RetroArch v1.15.0

same behavior on Windows x86 and linux arm

davidgfnet commented 8 months ago

I think this is now fixed right @schmurtzm ?

schmurtzm commented 8 months ago

I think this is now fixed right @schmurtzm ?

Yes fixed thanks to #16014 ! Tested on Windows and Linux (Miyoo Mini).

thanks a lot !