search

libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.32k stars 1.84k forks source link

[Menu] Menu sub label finetunes and file names in on-screen notifications #16146

Open davidhedlund opened 9 months ago

davidhedlund commented 9 months ago

Sub-labels

Settings

Replace "file browser" with "File Browser":

Add sub-label "(Restart required)":

Rename "Save Configuration on Quit" to "Save Configuration on Quit for this Session"

"Requires restart" sub-label

Asked in https://github.com/libretro/RetroArch/issues/16146#issuecomment-1981823441

"These are all entries in "Settings -> Drivers". Can someone please answer which one that should have the sub-label "Requires restart.", because I don't know how to test them?:

When the "Controller" entry has "Requires restart", document that we encourage users to generate and upload autoconfig files for all controller drivers at https://github.com/libretro/docs/pull/910

Quick Menu

The requirement is not added, it is: "Requires first that file(s) has been saved via option(s) at 'Controls -> Manage Remap Files'.":

Missing directories in Settings -> Directory

core_options_path

core_options_path = ""

Replace in https://github.com/libretro/RetroArch/blob/master/retroarch.cfg

# Path to core options config file.
# This config file is used to expose core-specific options.
# It will be written to by RetroArch.
# A default path will be assigned if not set.
# core_options_path =

with

# Path to core options config file.
# This config file is used to expose core-specific options.
# It will be written to by RetroArch.
# A default path will be assigned if not set.
# This setting depends on
#   global_core_options = "true"
# core_options_path =

video_font_path

video_font_path = ""

# Path to a font used for rendering messages. This path must be defined to enable fonts.
# Do note that the _full_ path of the font is necessary!
# video_font_path =

video_font_path is set to video_font_path = "" for the Flatpak package, and the Appimage.

Document

Comment these variables in https://github.com/libretro/RetroArch/blob/master/retroarch.cfg

bundle_assets_dst_path = ""

bundle_assets_src_path = ""`

See also

Done

Replace "system directory" with "System/BIOS directory":

cursor_directory = "/app/share/libretro/database/cursors"

resampler_directory = ""

Replace "DualAnalog" with "Dual Analog":

Shaders -> Prepend Preset / Append Preset (solved via https://github.com/libretro/RetroArch/pull/16095/files)

Per https://github.com/zoltanvb/RetroArch/commit/ee9e68cb372d2abc07a6facb4a6ee8a3f9b9af3c and https://github.com/libretro/RetroArch/commit/14ce660a38f99d448b32ed752ddaf1f250dcf669 :

Per https://github.com/libretro/RetroArch/pull/16144/files

Per https://github.com/libretro/RetroArch/issues/16121

Bisect Results

[Try to bisect and tell us when this started happening]

Version/Commit

You can find this information under Information/System Information

Environment information

hizzlekizzle commented 9 months ago 
Main Menu -> Online Updater -> Updater Settings -> On-Demand Thumbnail Downloads: "Automatically download missing thumbnails while browsing playlists" <-- s/playlists/the Playlists directory/
Main Menu -> Online Updater -> Information -> Database Manager: "View databases." <-- s/View databases/View files in the Database directory/

I disagree with these. In neither case are you browsing the directory. You're browsing the contents of the files.

While I like the idea of including the full paths, there's no way most full paths are going to fit in the notification widgets. I suggest including the full path in the logs if they're not already, though.

davidhedlund commented 9 months ago 
Main Menu -> Online Updater -> Updater Settings -> On-Demand Thumbnail Downloads: "Automatically download missing thumbnails while browsing playlists" <-- s/playlists/the Playlists directory/
Main Menu -> Online Updater -> Information -> Database Manager: "View databases." <-- s/View databases/View files in the Database directory/

I disagree with these. In neither case are you browsing the directory. You're browsing the contents of the files.

I removed them, thank you for reading through the whole list!

Do you prefer single quotes or not?:

While I like the idea of including the full paths, there's no way most full paths are going to fit in the notification widgets.

We could add just file names (like for the Online Updater -> Update Assets -> Update* entries) to begin with. Also, the file names are not fully included currently. I just submitted:

davidhedlund commented 9 months ago

@zoltanvb Please participate in this issue if you want, since you commited:

hizzlekizzle commented 9 months ago

I'd probably go with no quotes, since that sort of thing can be difficult to convey in translations.

davidhedlund commented 9 months ago

While I like the idea of including the full paths, there's no way most full paths are going to fit in the notification widgets. I suggest including the full path in the logs if they're not already, though.

I just submitted this, if you are interested:

davidhedlund commented 8 months ago

@zoltanvb I updated all entries in the top post:

zoltanvb commented 8 months ago

Prepend sublabel was fixed by #16095. Resampler directory seems unused nowadays, can probably be removed from the code. Video font directory gets initialized when browsing for a new font so probably it is not needed to have it configurable separately. Core options path is only used when global core options are enabled (and in that case it points to one file called retroarch-core-options.cfg). Cursor directory is not used any more (views are saved next to playlists), few traces are still in the code that could be removed. Bundle_assets dirs are used, but that should probably not be user configurable. DualAnalog is coming from the core(s) directly, so that does not depend on RA,

davidhedlund commented 8 months ago

@zoltanvb I updated all entries in the top post:

* Made all text significantly more readable.

* Merged fixed entries under the "Done" section

I repeated this with your new information. Thank you once again.

davidhedlund commented 8 months ago

Merged to the Done section in the top post: Replace "system directory" with "System/BIOS directory"

Thanks!

davidhedlund commented 3 months ago

Found that "Maximum Users" requires restart to functioning, which should be added to its sub-label:

Settings -> Input -> Maximum Users Sub-label: "[Current text ] (Restart required)"