libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.39k stars 1.84k forks source link

[Bug] Rewind breaks when Retroachievements is enabled. #16340

Open MavisCelus19201 opened 8 months ago

MavisCelus19201 commented 8 months ago

First and foremost consider this:

Description

Rewind randomly just resets the game entirely, it didn't always do this but when it starts it never seems to stop.

Expected behavior

Rewind works like normal

Actual behavior

Rewind immediately resets the game to the beginning regardless of position.

Steps to reproduce the bug

I narrowed it down to RetroAchievements so the steps are

  1. Enable Rewind and Retroachievements, without hardcore mode. 2, Load any game, game doesn't matter but I noticed it with these cores. [Beetle VB Stella mGBA Snex9x GenesisPlusGX Geolith NeoCD Fceumm]
  2. Try to rewind, keymapping, video drivers and rewind settings don't seem to matter.

Bisect Results

I didn't change my rewind settings prior, regenerating the config file only fixed a little bit of it before it started happening again, using an old config, shuffling core remaps and configs, and even remapping rewind to something else to make sure it wasn't some shared input issue didn't change it at all.

I've narrowed it down to enabling RetroAchievements, if I enable it at all, then it causes issues with rewind, but disabling it immediately fixes it even after a restart. This is without hardcore mode enabled, and in fact enabling that on a game that RA doesn't support lets rewinds work fine, but disabling it breaks it again.

Version/Commit

You can find this information under Information/System Information

Environment information

OS is Manjaro 6.6.19 Video Drivers tested were Vulkan, glcore, gl. All with the same issue.

Jamiras commented 8 months ago

Could not reproduce using GenesisPlusGX or Snes9x on latest master on Windows 11 with Vulkan or GL driver.

rbisker commented 8 months ago

I can reproduce this issue on JELOS OS using ganbatte emulator. Rewind resets GBC games with retroachievements enabled, works as expected once RA is disabled

0xb011 commented 8 months ago

I am experiencing similar issue on Android. In my case it works properly again after disabling and re-enabling rewind via Quick menu as documented by someone else here. The catch is I have to do it every play session...not ideal.

Clydefrosch22 commented 6 months ago

running into the same issue on a rg35xx h (Linux Based) running MuOS with 1.18.0 (Build Date April 21 2024, 64 bit) so far, games seem to reset upon touching the rewind key, whenever retroarchievements are set to on, but the game itself actually doesnt have any achievements on the side, i.e. many romhacks or bad dumps

any game with achievements can rewind fine so far.

Both, turning off and on hardcore mode in achievements menu or turning off and on rewind will make rewind work for the session.

the only workaround i have so far is turning off achievements entirely and saving a game overwrite. when achievements dont run at all, everything is fine.

furthermore, if hardcore mode is enabled from the getgo, rewind also works normally.