libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.24k stars 1.83k forks source link

RetroArch 1.19 Android crashing to home screen on Retroid Pocket 4 Pro when loading NES game TMNT 2 The Arcade Game w/achievements enabled #16648

Closed ejleslie closed 4 months ago

ejleslie commented 4 months ago

Description

If RetroAchievements are enabled when loading NES ROM "Teenage Mutant Ninja Turtles 2: The Arcade Game" with any NES core on the Android version of RetroArch 1.19, the game will begin to load but then immediately crash to the Android home screen. If achievements are disabled, the game will load and play normally.

Expected behavior

The ROM should load and play properly whether achievements are enabled or not.

Actual behavior

If achievements are enabled, RetroArch crashes to the Android home screen.

Steps to reproduce the bug

  1. Enable achievements in the Android build of RetroArch 1.19 (in my case done on the Retroid Pocket 4 Pro).
  2. Load the NES ROM "Teenage Mutant Ninja Turtles 2: The Arcade Game" using any NES core.
  3. RetroArch will crash to the Android home screen.
  4. Disable achievements, and the ROM will then load properly.

Bisect Results

I saw this behavior in 1.18 before updating my RetroArch to 1.19 in hopes that it had been corrected, but it was still happening. I do not know if it behaved this way prior to 1.18.

Version/Commit

You can find this information under Information/System Information

Environment information

ejleslie commented 4 months ago

This bug also discussed (and confirmed by another user) on the Retroid subreddit.

gouchi commented 4 months ago

May you try to provide some log ?

Thank you.

ejleslie commented 4 months ago

Sure - here are two logs showing an attempt to run the game with Vulkan and OpenGL output. In both cases you can see the log ends (because RetroArch has crashed) right after the RCHEEVOS log lines indicating it is trying to start the session. retroarch2024_06_0303_24_11.log retroarch2024_06_0303_26_49.log

ejleslie commented 4 months ago

The problem is also being discussed by folks on the RetroAchievements page for the game (scroll to bottom), where users indicate they've seen this behavior since June 1. It can also be seen in the first five minutes of this Youtube video from Jeff Gerstmann this week.

Jamiras commented 4 months ago

This is a problem with bad data on the server being exposed differently by the recent RAWeb release. It's not a RetroArch problem. We'll get the data cleaned up and the server patched. I'll reply again once it's been addressed.

Jamiras commented 4 months ago

The bad data has been corrected. I've also opened a PR to prevent this from happening again in the future. I believe this can be closed.

ejleslie commented 4 months ago

Looking good on my end now! Thanks for the quick turnaround.

odditude42 commented 4 months ago

I'd argue this is still a bug that should be resolved - bad data from the retroachievements server shouldn't cause a local crash, rather an exception that should be handled gracefully.