CRT-Royale shader broken in Vulkan as of the 7/22/2024 nightly

[boomercore]

Description

While rendering with Vulkan, loading any Royale slangp preset or my modified ones, results in either a black or blurry screen. D3D12 still works fine.

Expected behavior

Royale loads fine in Vulkan as it does in a July 10th build I rolled back to. Not 100% sure on when it broke.

Steps to reproduce the bug

1. Selected the Vulkan display driver
2. All shaders seem to work except for Royale and any presets that rely on it, even when I update the slangp shaders from the repo.

Bisect Results

Happened upon updating to the latest nightly as of 7/23/2024, rolling back to the 10th fixes it

Version/Commit

RetroArch: 1.19.1 Git Version 2c31de5 Build Date Jul 23 2024

Environment information

Win11 / 4070 / Zen 3 platform

To further confirm the issue I unzipped the newest build into its own folder with stock settings, downloaded the Mesen core (happens regardless of core), flipped to the Vulkan driver, and downloaded the slang shaders. This is what CRT-royale from slangp/crt/ gives me:

This is what the Jul 10 version gives me and is expected:

[hizzlekizzle]

Can you try a few more nightlies to see if you can pinpoint when it broke for you? There were some vulkan-related commits 2 days ago, so if you could try the nightly from 3 days ago and, if that one works, try the one from 2 days ago. That should narrow it down significantly.

EDIT: FWIW, royale-based presets (and others) are still working fine for me with the latest nightly.

EDIT2: Nvm, I didn't compile the latest. Once I did that, I'm getting segfaults with vulkan on shader load.

[boomercore]

Definitely as of 7/22 for me. 7/21 and earlier are fine.

[hizzlekizzle]

I put in a PR that fixes my segfaults, so perhaps it will help with this, as well.

[boomercore]

Fixed as of the latest update. Thanks a lot.

[hizzlekizzle]

Np! Thanks for confirming :)