search

libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.29k stars 1.84k forks source link

[Android] Using JPG for boxart shows weird colours #16927

Open zzedmore opened 2 months ago

zzedmore commented 2 months ago

This commit https://github.com/libretro/RetroArch/pull/16806 added JPG support for Boxart. I tried this on two different Android devices (Phone and Retroid Pocket Handheld) but the jpg's seem to have weird colours --

361137189-0d86cf8f-683d-4668-8007-fd7ebf4fe798

It works fine on Windows.

Here is the source jpg example --

361136899-70cd3ff3-f2bf-44a3-aaad-b1c6ba7e042b

gnubeest commented 2 months ago

I'd have to double-check, but i'm 99% certain a very similar effect was happening for me (using png thumbnails autofetched from the server) whenever I turned on thumbnail bilinear filtering on rgui in the current iOS App Store build (which predates the jpg commit but may still be related).

EDIT: It happens for me in rgui when I set the thumbnail downscaling method from bilinear to sinc/lanczos3 without restarting. I haven't played with downscaler settings in any other menu. Are your jpegs a higher (or even lower) resolution than the pngs you've been using? This may already be reported somewhere.

IMG_0049 IMG_0048

zzedmore commented 2 months ago

I tried setting the Thumbnail Upscaling Threshold to different values but it made 0 difference. Not sure where 'Downscaling Method' is. The jpgs I use are 700 pixels on the longest side. Example one above (Alien 3).

zoltanvb commented 2 months ago

Reproduced by loading the image with the image viewer core, so the problem is probably in the platform specific jpeg handling somewhere.