libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.38k stars 1.84k forks source link

RetroAchievements: hash generation failed for GameCube ISO #16949

Open jonian opened 2 months ago

jonian commented 2 months ago

Description

GameCube .iso roms fail to generate RetroAchievements hash.

Version/Commit

Environment information

Relevant logs

[INFO] [RCHEEVOS]: Found 4 potential consoles for iso file extension
[INFO] [RCHEEVOS]: Trying console 21
[INFO] [RCHEEVOS]: game.iso
[INFO] [RCHEEVOS]: Could not locate primary executable
[INFO] [RCHEEVOS]: Trying console 41
[INFO] [RCHEEVOS]: game.iso
[INFO] [RCHEEVOS]: Not a PSP game disc
[INFO] [RCHEEVOS]: Trying console 43
[INFO] [RCHEEVOS]: game.iso
[INFO] [RCHEEVOS]: Not a 3DO CD
[INFO] [RCHEEVOS]: Trying console 9
[INFO] [RCHEEVOS]: game.iso
[INFO] [RCHEEVOS]: Not a Sega CD
[INFO] [RCHEEVOS]: Load failed (-25): hash generation failed
[INFO] [RCHEEVOS]: RetroAchievements game load failed: hash generation failed
RenanSD007 commented 2 months ago

Only Standalone supports RetroAchievements, the core is too outdated to support it (same for PCSX2)

jonian commented 2 months ago

@RenanSD007 I'm working on an updated core here. The old core exposes ram from what I can see here, so it will probably work if the game is identified.

Anyways, the issue is about identification not working and if the core supports it is irrelevant.

warmenhoven commented 2 months ago

jonian has been working on updating the core, but the iso hash generation/verification would be done by the frontend anyway.

RenanSD007 commented 2 months ago

I didn't know that 😅 sorry for the inconvenience

jonian commented 2 months ago

It seems that the issue has been fixed 2 weeks ago in RetroAchievements/rcheevos#353, so the rcheevos module needs updating. With the updated rcheevos it works even with the current (outdated) core!

Current core Updated Core
Screenshot from 2024-09-01 22-24-45 Screenshot from 2024-09-01 22-19-23
[INFO] [RCHEEVOS]: Registered 0x1800000 bytes of SYSTEM RAM at $000000 (offset 0x000000)
[INFO] [RCHEEVOS]: 129/129 memory addresses valid
[INFO] [RCHEEVOS]: Game 4325 loaded, hardcore enabled
[INFO] [RCHEEVOS]: You have 0 of 49 achievements unlocked.