libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.17k stars 1.82k forks source link

[UI Bug] in XMB mode dynamic wallpaper won't change in the NES column #2428

Closed bronnel closed 8 years ago

bronnel commented 8 years ago

In XMB mode when you navigate to NES (Nintendo Entertainment System ) tab, the dynamic wallpaper doesn't change, I tested about 9 other cores all were showing up just fine , only on NES column it doesn't change (instead it shows the neighboring core wallpaper). I already made sure the corresponding png image is available in assets folder (Nintendo - Nintendo Entertainment System.png), and defined the path properly Here is what I'm talking about http://youtu.be/bED5SDBDfcA

bronnel commented 8 years ago

I just noticed this is a part of a bigger issue, I was wrong to think it was related to NES tab. If you notice the first item in NES tab (super mario bros) have boxart, so if you delete its boxart png file or turn off (display boxart) in settings, then the wallpaper will show up, so this means there is a conflict between dynamic wallpaper and boxart.

I already reproduced this bug for Playstation tab

How to reproduce this bug 0- get in XMB mode 1- enable boxart 2- enable dynamic wallpaper 3- off course set the path for wallpaper and boxart 4- make sure the first item (game) in each tab (core) have a boxart and displayed properly 5- when you navigate to that tab (core) in which the first item have a boxart, then the dynamic wallpaper will not change ( won't show up ), instead it shows the neighboring wallpaper.

bronnel commented 8 years ago

image image image

bronnel commented 8 years ago

This issue was available throughout all recent (oct-nov) builds

bronnel commented 8 years ago

I reproduced this bug multilpe times and on different platforms it's the same

andres-asm commented 8 years ago

It will be looked at eventually

On Thu, Nov 19, 2015, 12:52 AM bronnel notifications@github.com wrote:

I reproduced this bug multilpe times and on different platforms it's the same

— Reply to this email directly or view it on GitHub https://github.com/libretro/RetroArch/issues/2428#issuecomment-157959345 .

kivutar commented 8 years ago

It is a real bug in our msg_queue code. When we push two msg with DATA_TYPE_IMAGE at the same time, the first one will be ignored and will lead to an empty texture. We need to fix this.

bronnel commented 8 years ago

Well thank you I cannot wait for you to fix this, you're an amazing developer

kivutar commented 8 years ago

@heuripedes just fixed this bug with his recent commits.

bronnel commented 8 years ago

I installed the latest build the wallpaper shows up now but the boxart doesn't show

kivutar commented 8 years ago

Now you have to follow this naming convention:

<boxarts_dir>/Nintendo - Game Boy/Named_Snaps/Zool - Ninja of the 'Nth' Dimension (Europe).png

You can grab image packs from there: https://screenshotpalace.wordpress.com/no-intro-screenshot-reloaded/

We needed to add folders because too much games share common names on different systems.

For now, the "Named_Snaps" string is hardcoded, but soon I will either remove it, or build a selection list with the following options: Named_Snaps, Named_Titles, Named_Boxarts.

We need to find a good source of Boxarts named after the no-intro rom names.

bronnel commented 8 years ago

great work , now both the wallpaper and the boxart showing up just fine. One million thanks to you

kivutar commented 8 years ago

Can somebody close this issue please?