libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
9.77k stars 1.77k forks source link

Can't load compressed cue+bin. #4094

Open ofry opened 7 years ago

ofry commented 7 years ago

Test case:

Any PSX game with cue+bin or cue+many bins in same archive. (example - from redump set).

If I try to open archive as folder and load .cue from it, then: 1) Extracted to cache folder ONLY this cue, not bin. 2) When core tried to load .bin, it will crash, because it isn't present in cache dir.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/39611471-can-t-load-compressed-cue-bin?utm_campaign=plugin&utm_content=tracker%2F296058&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F296058&utm_medium=issues&utm_source=github).
bootsector commented 7 years ago

Have you checked if the referenced .bin files have the correct case inside the .cue file?

Edit: Just noticed you mentioned a compressed file, so my suggestion might not apply.

ofry commented 7 years ago

Yes. And my OS is Windows 8.1 x64, so FILE.bin and File.bin and file.bin is same filename.

ghost commented 7 years ago

You can currently only load .bin files from an archive, which means that multi-disc/track games are not supported this way. If you choose the cue file instead of the bin, it's not smart enough to extract the other file(s) yet.

ghost commented 7 years ago

this is a similar behavior with the issue i posted in pce-cd, it will only extract the cue sheet but not the iso/bin

lasers commented 7 years ago

Linking retro-wertz's issue: https://github.com/libretro/RetroArch/issues/4003

andres-asm commented 7 years ago

It's not supported... compressing cue+bins is rather pointless anyway since extracting would take a looooong time and use quite a bit of ram and would need to be performed every single time you load the game.

Also what if a user has 100 roms (goodsets for instance) and loads one. We either extract everything from the zip or we write a cue parser.

And then what if someone want's to use the toc format or any other format.

And what about a multi cue + multi bin m3u.

Supporting every possible combination of things under the sun won't help us. It will make the codebase huge and full of bugs.

ofry commented 7 years ago

Redump sets have format: game.zip => (cue + bins for this cue) or game (disc 1).zip => (cue + bins for disc 1 only).

So if user is pirate and uploading from his PC, he ought to have compressed and uncompressed sets either :( More than double disk space usage :(

andres-asm commented 7 years ago

My point stands.

ofry commented 7 years ago

And I think CUE and M3U parsers will help to create playlists from RA.

ofry commented 7 years ago

Maybe, if VFS will merge, then if core "asks" more files, then try to get it same way as initial file.