libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.31k stars 1.84k forks source link

"Save Core override" ignores "Dynamic Audio Rate Control" setting #5421

Open ofry opened 7 years ago

ofry commented 7 years ago

First and foremost consider this:

Description

"Save Core override" ignores "Dynamic Audio Rate Control" setting

Expected behavior

"Dynamic Audio Rate Control" setting should be overwritten in current core.

Actual behavior

"Dynamic Audio Rate Control" setting value goes to position in main configuration.

Steps to reproduce the bug

  1. Go to "settings" => Audio.
  2. Set value "Dynamic Audio Rate Control", for example, to 0.450.
  3. Exit Retroarch (for save this config).
  4. Open any game with any core (tested on FCEUmm).
  5. Go to "settings" => Audio.
  6. Set value "Dynamic Audio Rate Control", for example, to 0.200.
  7. Save "Core Override".
  8. Go to "settings" => Audio again.
  9. You see value 0.450 again.

    Bisect Results

[Try to bisect and tell us when this started happening]

Version/Commit

You can find this information under Information/System Information

Environment information

ofry commented 7 years ago

This bug presents in latest nightly 14f57ca

andres-asm commented 7 years ago

It's not up to me, it was moved from the settings struct to avoid excessive pointer grabbing. If it was changed it was for a reason, I won't move it back myself.