search

libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.17k stars 1.82k forks source link

Incorrect playlist file being generated when scanning a directory #6321

Closed kevinheaslip closed 5 years ago

kevinheaslip commented 6 years ago

When scanning a directory containing SNES ROMs, Nintendo\ -\ Super\ Nintendo\ Entertainment\ System\ Hacks.lpl is created, not Nintendo\ -\ Super\ Nintendo\ Entertainment\ System.lpl. This leaves a black box where the system and cartridge icons should be in the GUI. All of the ROMs in the playlist are also their original file names, and not the cleaned up names from the database. This is the only system this seems to happen for.

snes-retroarch

I have bsnes v094 (Balanced) aea144e core and the most recent databases from the online updater.

This must have happened as of the last update, it wasn't happening in the previous stable build I got from the Ubuntu PPA last week. I reinstalled Ubuntu 17.10 last night and set up a fresh install of Retroarch and discovered the issue.

Git version: 6fc6bfb

Ubuntu 17.10

I am relatively new to Linux, so you may have to bear with me for follow up information.

RobLoach commented 6 years ago

Thanks for bringing this up. We had moved GoodTools entries over to the Hacks database to reduce the SNES database size. GoodTools includes pretty much everything (hacks, old versions, etc), while No-Intro is clean.

@twinaphex I think we could do a few things...

  1. Rename the "Hacks" suffix to "Extras"
  2. Make sure the image is in there for the assets

What do you think?

kevinheaslip commented 6 years ago

Sure thing. Looking at my files I've just realized that these ROMs are actually from a No-Intro source, so I'm not sure why they should be displayed as having GoodTools file names.

Thanks for looking into this!

RobLoach commented 6 years ago

Ah, perhaps they appear in both sources, finds it in Hacks, and then uses that.... Try deleting the Hacks rdb?

jyggen commented 6 years ago

I'm having the same issue, and deleting the Hacks rdb and rescanning does indeed create a "normal" SNES playlist with the roms.

RobLoach commented 6 years ago

Removing GoodSNES could be a thing: https://github.com/libretro/libretro-database/pull/580

kevinheaslip commented 6 years ago

Deleting the hacks rdb did the trick, thank you!

inactive123 commented 6 years ago

Renaming Hacks to Extras could be a good solution, yes.

RobLoach commented 6 years ago

Just removed GoodSNES entirely. All it causes is issues.

trumad commented 6 years ago

Whereabouts can I find the rdb file? I'm running retroarch 1.7.1 on FireStick. Maybe this will be fixed with 1.7.2?

RobLoach commented 6 years ago

You can run the Update Databases to retrieve the latest .rdb files. Unsure where they store when rnning on a FireStick.

Indefiance commented 6 years ago

On Firestick. Got to settings>directory>databases. Change the default directory to a location you have access to. Then go back to online updater and update databases. Quit retroarch to save settings. Start up and rescan your files. Yo may have to delete your snes hacks playlist files under Esfile explore ( sdcard/Retroarch/playlist/)

Pearate commented 6 years ago

Deleting the "Nintendo - Super Nintendo Entertainment System Hacks.rdb" fixe the problem. But now, how to delete the SNES Hacks Icon (Empty list) in the menu ? I just want to have the SNES icon.

orbea commented 5 years ago

This seems to be a fixed issue and if anyone has lingering issues they should remove the bad databases, playlists and then rescan the content.

If anyone still has any issues please let us know!