libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.3k stars 1.84k forks source link

(Menu) Set Menu Options defaults based on Menu Color Theme #6380

Open RobLoach opened 6 years ago

RobLoach commented 6 years ago

Coming from https://github.com/libretro/RetroArch/pull/6379 , it would be great to set the text color to be black or white automagically when the user flips through the Menu Color themes.

When the user switches to "Light" or "Morning Blue" themes, have the text color switch to black. On all other themes, flip it to white text. 37260696-8f720258-256c-11e8-94c6-345edc809d70

anyputer commented 6 years ago

Should the same also happen with the icon theme if it's set to Monochrome?

RobLoach commented 6 years ago

That's a great idea... Flip between Monochrome and Monochrome Inverted if they're set to either Monochrome?

anyputer commented 6 years ago

Yeah, if the theme is set to Monochrome it will be inverted just like the text.

andres-asm commented 6 years ago

I think themes should be defined by a file instead of the current hardcoded approach. We would list all the .theme files in the theme selector, and the themes would basically have:

The hardcoded approach we have now is flat out bad, if the assets are missing the themes are still listed. It would also allow people to add themes without adding more stuff to the codebase.

RobLoach commented 6 years ago

The introduction of .theme files sounds like a great idea. Live in RetroArch Assets?

blizzrdof77 commented 4 years ago

I accidentally changed my theme to white, and now I can't get it back because the text and icons are also white. I've had to restore my system completely. Thus, I say this should be prioritized!