libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.06k stars 1.81k forks source link

Regression: keyboard type mappings are not functional when mapped to the touchscreen overlay (android) #6751

Open ClockGen opened 6 years ago

ClockGen commented 6 years ago

Description

Related to #6631 and #6700.

Using dosbox core, mapped keyboard keys to the touchscreen overlay are not functional. With user device type as gamepad, remapping works, but, with only gamepad buttons available, there is not much use of that in dosbox. Keyboard mappings were working before in version 1.7.1 and earlier.

Expected behavior

Working keyboard to touchscreen overlay mappings with user 1 device type as keyboard+mouse.

Actual behavior

Mappings can be assigned, but they never work: only gamepad-type user device mapping works, even if current user device is keyboard+mouse.

Steps to reproduce the bug

  1. Start dosbox core
  2. Open quick menu, open controls
  3. Change user 1 device type to keyboard+mouse
  4. Exit back to quick menu and open controls again to refresh
  5. Map any keyboard keys to the gamepad buttons (for example keyboard arrows to the d-pad and letter keys to a, x, b and y gamepad buttons)
  6. Back in the dosbox, try to press mapped keys to get some input (like entering some text into dosbox prompt)

Bisect Results

After the new nightly RetroArch update that changed the input mapping.

Version/Commit

Environment information

andres-asm commented 6 years ago

I made the whole keyboard mapper and I'm 100% certain that I never intended to make the keymapper work with overlays.

If it ever worked it was luck or undefined behavior.

Anyway. I guess the issue is valid. I don't have time for it now. Maybe someone else can fix it.

On Wed, May 9, 2018, 10:19 AM ClockGen notifications@github.com wrote:

Description

Related to #6631 https://github.com/libretro/RetroArch/issues/6631 and

6700 https://github.com/libretro/RetroArch/issues/6700.

Using dosbox core, mapped keyboard keys to the touchscreen overlay are not functional. WIth user device type as gamepad, remapping works, but, with only gamepad buttons available, there is not much use of that in dosbox. Keyboard mappings were working before in version 1.7.1 and earlier. Expected behavior

Working keyboard to touchscreen overlay mappings with user 1 device type as keyboard+mouse. Actual behavior

Mappings can be assigned, but they never work: only gamepad-type user device mapping works, even if current user device is keyboard+mouse. Steps to reproduce the bug

  1. Start dosbox core
  2. Open quick menu, open controls
  3. Change user 1 device type to keyboard+mouse
  4. Exit back to quick menu and open controls again to refresh
  5. Map any keyboard keys to the gamepad buttons (for example keyboard arrows to the d-pad and letter keys to a, x, b and y gamepad buttons)
  6. Back in the dosbox, try to press mapped keys to get some input (like entering some text into dosbox prompt)

Bisect Results

After the new nightly RetroArch update that changed the input mapping. Version/Commit

  • RetroArch: 1.7.3-git (automatic build from may 9 in f-droid repository), 1.7.2 (f-droid repository)

Environment information

  • OS: Android 7.1.2

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/libretro/RetroArch/issues/6751, or mute the thread https://github.com/notifications/unsubscribe-auth/ABpC0GmUE1Pa0EnC02v9xtFZFlnlnULfks5twwj0gaJpZM4T4gtB .