libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.04k stars 1.81k forks source link

FBA WiiU broken #6777

Closed andres-asm closed 6 years ago

gblues commented 6 years ago

I'm testing a theory.

gblues commented 6 years ago

I think it has to do with the fact that the enums are changed by inserting a new value in the middle, which causes the "Wii U" enums to shift by 1. So maybe there's something somewhere using the raw enum value (8) instead of the mnemonic MENU_VIDEO_DRIVER_WIIU or FONT_DRIVER_RENDER_WIIU, in a code path only FBA is hitting? 🤷‍♂️

cucholix commented 6 years ago

gblues_fba_build I just tested @gblues build 6f12152 With Metal Slug

barbudreadmon commented 6 years ago

Hmmm could it be related to the size of the executable or something ? Did you try building it against a fbalpha core stripped of some drivers (NO_MD=1 NO_PCE=1) ?

gblues commented 6 years ago

Nah, it's not. We had a bad build. I gave @cucholix my build and it worked for him too.

Next step is seeing if it's one enum or the other, hopefullly not both.

barbudreadmon commented 6 years ago

Ok, that's good news ! The fact it only affects the fba core is weird though.

gblues commented 6 years ago

Indeed!

As an update, I've isolated it to the menu driver enum. Re-adding the font driver enum entry did not break it.

gblues commented 6 years ago

or not. Builds from master also work.

I tested with the 1.7.3 release and got a black screen, no DSI error. I then tested with the newest nightly, and it works.

Can anyone having this trouble please re-test with the latest nightly RPX? Because it's working on my system with mslug1.

cucholix commented 6 years ago

It's working with latest nightly, even CPS3, no idea what happened

inactive123 commented 6 years ago

Can this be closed or is it still ongoing?

barbudreadmon commented 6 years ago

I think you can, while having other issues (speed and big endian), fbalpha doesn't crash anymore on Wii U.