Closed orbea closed 5 years ago
@krzys-h Can you take a look at this?
@krzys-h After looking at that commit for a while I spotted the problem...
diff --git a/verbosity.c b/verbosity.c
index 7a9cfccbd5..e9b9d2269d 100644
--- a/verbosity.c
+++ b/verbosity.c
@@ -65,11 +65,7 @@
* will write to this file. */
static FILE *log_file_fp = NULL;
static void* log_file_buf = NULL;
-#if _DEBUG
-static bool main_verbosity = true;
-#else
static bool main_verbosity = false;
-#endif
static bool log_file_initialized = false;
#ifdef NXLINK
On non-console platforms verbosity should only be turned on with retroarch --verbose
or by turning it on in the menu settings. What were you trying to achieve here?
These log messages already existed but they are printed before the config file and command line parameters are loaded, meaning they never appear otherwise - and I needed them to debug why my config file was not loading properly. Perhaps changing this globally was not the best idea but to be honest, I forgot I even did this.
Would you mind if I changed it back so its not set globally?
Sure, feel free to change it back. I needed it only for a while and probably would have reverted it myself if I remembered.
Logging messages that are never outputted anywhere make no sense though.
Logging messages that are never outputted anywhere make no sense though.
I fully agree, maybe they should be refactored to appear after the cli is initialized? However that change is more involved and out of scope of this issue report. :)
Description
When running a debug build of RetroArch it will now print this.
Full log - https://pastebin.com/wup8CVMG
And for reference a full log with the previous good commit.
https://pastebin.com/VfyegbWQ
And the diff.
I have not noticed any visible regressions in RetroArch, but its very possible I am not looking at the right places.
Expected behavior
No output should be printed.
Actual behavior
Steps to reproduce the bug
Bisect Results
b201d669b5ea1470bb239036aa944342a0591a95
Version/Commit
You can find this information under Information/System Information
Environment information
Slackware64-current
gcc-8.2.0