search

libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.21k stars 1.82k forks source link

[Android] hotkey open menu does not work anymore #9044

Open TobyKaos opened 5 years ago

TobyKaos commented 5 years ago

Description

Before the build of 21th of june I can open quick menu by pressing guide button on my gamepad (8bit do f30 pro). I try to setup quick menu hotkey but none works.

Expected behavior

Guide button or hotkey (L3+R3 or others) open the quick menu.

Actual behavior

Guide button or hotkey does not open quick menu when a game is launched.

Steps to reproduce the bug

  1. Download a nightly builds after the 21th (I try 26th, 1st july) and install it on android device
  2. Load a core and launch it
  3. Try to open quick menu (button guide or hotkey). Nothing happens

Bisect Results

I download the nightly builds of 20th June and all is ok. The commit I think introduce this bugs is: 20e8dfcba5fc36befb129940d14a1d891b38f2e2

Version/Commit

You can find this information under Information/System Information

parkerlreed commented 5 years ago

Same here. Both Hotkey and Game Combo are both broken.

Nvidia Shield Portable on 6.0.1 and

Pixel 3 XL and DS4 on 10 (Q beta)

These are broken on the nightlies for me as well. Both devices.

parkerlreed commented 5 years ago

Also dinput/xinput aren't on Android. It's more than likely one of these

https://github.com/libretro/RetroArch/commit/affa93bd98207b9a2d83c03a74fb320a77d307e2

https://github.com/libretro/RetroArch/commit/ef0cedd798c3448b6f42b3eb2797e6b026669744

ZandigSlaytanic commented 5 years ago

Same issue here (hotkey and game combo) using Nvidia Shield TV

inactive123 commented 5 years ago

I hope this commit will fix it -

https://github.com/libretro/RetroArch/commit/13aab06d2d250aea29f81e052929170d23ff1ada

Check the latest nightlies within half a day or so to see if this fixed it.

TobyKaos commented 5 years ago

Will try tomorrow when a new NB come out. thx

TobyKaos commented 5 years ago

It is better but...

setup a combo key works now (start + select tried) and the quick menu show up. But the guide button does not work and if I try to assign a button to the show on off menu then retro arch display indisponible -2 and it become impossible to move in the menu. I must kill process. I stay on the 20th june release that works fine.

andres-asm commented 5 years ago

Ugh... Yeah +1 Hotkey enable no longer works, so my whole setup is broken.

For example hotkey button + (R3 in my case) + R2 no longer takes screenshots R3 + left analog X+ no longer fast forwards

Etc. quite the nasty regression

andres-asm commented 5 years ago

To clarify this regression is not android exclusive, happens on windows too no actually no, android only in-fact

inactive123 commented 5 years ago

I can only try fixing this once I get the Android Studio/Gradle solution up and running. This is probably tomorrow or so. There is some things @webgeek1234 and me still need to figure out before things will compile with Android Studio, but with a bit of luck we should be able to do that tomorrow. After that, I'll write documentation on LIbretro Docs too so that from this point on, everybody can easily compile RA Android with the modern SDK.

TobyKaos commented 5 years ago

Hi, do not worry we can continue using NB 20th of july. As I mentionned the issue is introduced in this commit or just after (NB 26th have the issue and maybe the 21th too because no other commit on Input code have been pushed after): https://github.com/libretro/RetroArch/commit/20e8dfcba5fc36befb129940d14a1d891b38f2e2

It is a simplification fix of the input. Maybe you can go backward?

jdgleaver commented 5 years ago

I just got a new Android device, and here's a small observation:

inactive123 commented 5 years ago

Update: we still dont have a working android studio implementation, still looking at that first.