search

libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.39k stars 1.84k forks source link

Shader preset per console #9073

Open yepyepyep4711 opened 5 years ago

yepyepyep4711 commented 5 years ago

Description

as some cores are used for several machines, being able to bind a shader to a machine instead of a core would be useful

Expected behavior

in the shader menu, I would expect to be able to bind a shader to a specific console instead of a specific core

Actual behavior

one can bind a shader to a core or a directory, not to a console, even though Retroarch knows for which console a rom is.

Steps to reproduce the bug

  1. choose a Game Boy rom and open it with a core
  2. choose a nice monochrome shader you like and make it a core preset
  3. open a game boy color with the same core
  4. see your game boy color game is not in colour anymore

Version/Commit

Environment information

andres-asm commented 5 years ago

RetroArch doesn't know what is being emulated at all.

hizzlekizzle commented 5 years ago

I believe this is exactly what 'save content directory preset' is meant to accomplish.

yepyepyep4711 commented 5 years ago

RetroArch doesn't know what is being emulated at all.

that's not what it looks like. In all the sets I've seen, GB and GBC are in one folder. Still, Retroarch displays one list for Game Boy and another for Game Boy Color, each under a miniature correctly displaying the corresponding console. The same thing happens if I add NES roms. Clearly Retroarch knows which is which. Hence it should be able to do per-machine settings, no?

yepyepyep4711 commented 5 years ago

I believe this is exactly what 'save content directory preset' is meant to accomplish.

I'm pretty sure that's what both directory presets and core presets aim to achieve. I'm just pointing out that "per console", regardless of directories or core, would be quite handy to have, as the existing presets don't always suit the situation. In this case, one core for two systems whose roms are in one folder, which seems to be the standard for GB&GBC

orbea commented 5 years ago

that's not what it looks like. In all the sets I've seen, GB and GBC are in one folder.

RetroArch only knows about scanned content, I suppose maybe you want to be able to set the shader based on the playlist used to load content?

yepyepyep4711 commented 5 years ago

that's not what it looks like. In all the sets I've seen, GB and GBC are in one folder.

RetroArch only knows about scanned content, I suppose maybe you want to be able to set the shader based on the playlist used to load content?

I'm not even sure what playlists are, but only being able to do this with scanned content would be fine.