libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.09k stars 1.81k forks source link

[static builds] history playlist not getting the db_name #9779

Open andres-asm opened 4 years ago

andres-asm commented 4 years ago

First and foremost consider this:

Description

Static builds do not get the core name into history (most likely due to load content on static doing an exitspawn)

As a result, the db name (and other fields are never populated, so history never gets thumbs on static. Example:

SNES Playlist on PC

{
  "version": "1.0",
  "items": [
    {
      "path": "W:\\roms\\Emulated\\Console\\Nintendo Super Nintendo Entertainment System\\Super Mario Kart (USA).zip#Super Mario Kart (USA).sfc",
      "label": "Super Mario Kart (USA)",
      "core_path": "D:\\GameData\\Emulators\\RetroArch\\libretro\\snes9x_libretro.dll",
      "core_name": "Nintendo - SNES / Famicom (Snes9x)",
      "crc32": "CD80DB86|crc",
      "db_name": "Nintendo - Super Nintendo Entertainment System.lpl"
    }
  ]
}

History on PC

{
  "version": "1.2",
  "default_core_path": "",
  "default_core_name": "",
  "label_display_mode": 0,
  "right_thumbnail_mode": 0,
  "left_thumbnail_mode": 0,
  "items": [
    {
      "path": "W:\\roms\\Emulated\\Console\\Nintendo Super Nintendo Entertainment System\\Super Mario Kart (USA).zip#Super Mario Kart (USA).sfc",
      "label": "Super Mario Kart (USA)",
      "core_path": "D:\\GameData\\Emulators\\RetroArch\\libretro\\snes9x_libretro.dll",
      "core_name": "Nintendo - SNES / Famicom (Snes9x)",
      "crc32": "CD80DB86|crc",
      "db_name": "Nintendo - Super Nintendo Entertainment System.lpl"
    }
  ]
}

GBA Playlist on WiiU

{
  "version": "1.2",
  "default_core_path": "sd:/retroarch/cores/mgba_libretro.rpx",
  "default_core_name": "Nintendo - Game Boy Advance (mGBA)",
  "label_display_mode": 0,
  "right_thumbnail_mode": 0,
  "left_thumbnail_mode": 0,
  "items": [
    {
      "path": "sd:/retroarch_data/gamedata/games/roms/Emulated/Console/Nintendo Gameboy Advance/Mega Man Zero (USA, Europe).zip#Mega Man Zero (USA, Europe).gba",
      "label": "Mega Man Zero (USA, Europe)",
      "core_path": "sd:/retroarch/cores/mgba_libretro.rpx",
      "core_name": "Nintendo - Game Boy Advance (mGBA)",
      "crc32": "9707D2A1|crc",
      "db_name": "Nintendo - Game Boy Advance.lpl"
    }
  ]
}

History on WiiU

{
  "version": "1.2",
  "default_core_path": "",
  "default_core_name": "",
  "label_display_mode": 0,
  "right_thumbnail_mode": 0,
  "left_thumbnail_mode": 0,
  "items": [
    {
      "path": "sd:/retroarch_data/gamedata/games/roms/Emulated/Console/Nintendo Gameboy Advance/Metroid Fusion (USA, Australia).zip#Metroid Fusion (USA, Australia).gba",
      "label": "",
      "core_path": "sd:/retroarch/cores/mgba_libretro.rpx",
      "core_name": "Nintendo - Game Boy Advance (mGBA)",
      "crc32": "",
      "db_name": "" <-----------------------------read here
    }
  ]
}

As you can see, db_name is empty.

Expected behavior

db_name should be populated so thumbnails can be shown, maybe exit spawn show have a db-name argument

Version/Commit

You can find this information under Information/System Information

Environment information

andres-asm commented 4 years ago

https://github.com/libretro/RetroArch/issues/8840