search

libretro / beetle-ngp-libretro

Standalone port of Mednafen NGP to the libretro API, itself a fork of Neopop.
GNU General Public License v2.0
11 stars 44 forks source link

save fix #17

Closed HerbFargus closed 8 years ago

andres-asm commented 8 years ago

That doesn't really fix anything... also it's saving correctly and in the correct folder for me. What is the issue to begin?

HerbFargus commented 8 years ago

The savestates work fine but the in game saves save in the system directory, this makes them default to the rom directory in the same place as the save states

As with all the mednafen emulators the savefile_directory doesn't seem to work

andres-asm commented 8 years ago

It's saving in the save directory for me.

andres-asm commented 8 years ago

Savestates are not saved by the core. They are always saved to whatever you have set as savestate dir because the frontend saves them. In-game saves may or not be saved by the frontend. In any case the code looks correct here.

If save directory is defined (the frontend must define this) it's setting it to RETRO_SAVE_DIRECTORY, otherwise it's saving in retro_base_dir which is in turn the SYSTEM dir.

If there is an error it would be the last part, base directory should be the rom dir. Not the system dir but fixing that would be more involved than this since base directory is being used to lookup for the firmware, I'll fix this later but this pull is not correct.

HerbFargus commented 8 years ago

yeah I guess you're right, the code behaves a bit differently with ngp than it does with the others, but yes the savefile_directory setting is still broken as you're aware.

I apologise for the noise.

andres-asm commented 8 years ago

nope, the savefile_directory setting is working correctly on all the platforms I tested and it's saving to the correct location, I tested:

It's correct, the only problem I see is it falling back to system dir instead of the rompath. The fix is wrong in the other repos too, I'll fix them all up by the weekend.

HerbFargus commented 8 years ago

Appreciated. I'll be happy to test any changes just to make sure that they are working as intended :)