libretro / beetle-ngp-libretro

Standalone port of Mednafen NGP to the libretro API, itself a fork of Neopop.
GNU General Public License v2.0
11 stars 43 forks source link

color correction (32-bpp) #74

Closed ghost closed 5 years ago

negativeExponent commented 5 years ago

for performance reasons, especially on slow devices, thought RA was to use 16 if possible. seems like 32bit is being hardcoded as the norm in this. isn't this color correction unavailable using shaders or a combination that edits params?

ghost commented 5 years ago

I couldn't replicate these pixel corrections using shaders so thought it would be useful, or for those who don't have hardware shader support. I don't want to eat more performance out of slower devices so I'll shut this down.

ghost commented 5 years ago

I think the 32-bpp code is good to add, if it isn't forced on everyone by default. Maybe for windows (msvc2017, mingw) or linux it'd make sense.

And the color modifier is not bad either. But it might work better as a standalone shader; it is just a 32 entry lookup table per color channel.

ghost commented 5 years ago

It was simple to port. Here's the result. https://raw.githubusercontent.com/tryal-star/glsl-shaders/color_curves/color-curves.glsl