libretro / beetle-pce-fast-libretro

Standalone fork of Mednafen PCE Fast to libretro
GNU General Public License v2.0
29 stars 55 forks source link

fix libretro fbo #112

Closed ghost closed 5 years ago

ghost commented 5 years ago

avoid random uninit values

ghost commented 5 years ago

the general purpose of update_geometry() is to update during width / height changes (eg. first/last scanline changes, overscan, resolution changes midgame etc). calling retro_get_system_av_info() in this case will apply the default width/height instead to geometry. you can just probably just fill up the remaining vars if this was the purpose, but update the base_width, base_height should be updated to whatever the emulation requests.

ghost commented 5 years ago

but update the base_width, base_height should be updated to whatever the emulation requests.

Ugh. Yes. Stupid mistake. Will fix.

I (sometimes) get incorrect values for max_width, max_height, fps. Like shaders start at 4096. Or slow fps. retro_get_system_av_info just nicely re-inits everything.