CD Image with external WAV audio crashes

[Tatsuya79]

It happens since July commits. Don't have nightlies archive to tell when exactly.

Tested with several cue+bin+ogg games that are working with older version. Win7 x64, nothing relevant in the log.

[inactive123]

Well, the only PC Engine CD games I usually test is Dracula X, and that still runs fine as of today (LInux x86_64).

[Tatsuya79]

Nothing in the log but I can see an "unsupported audio file format" in the retroarch dos window if I launch without logging. Tried with ogg and with wav images, both crash at launch.

[inactive123]

Guess we'll have to dissect it.

On a sidenote: I really, really dislike how the Mednafen author turned this into a kitchensink of audio formats which Mednafen PSX supports, which will lead to more and more sites putting up all sorts of dumps with varying audio format containers and the like. That's a bullet that should have been dodged so that we could have one proper set of CD dumps instead of all these confusing audio formats which require us to pull in all sorts of bloated dependencies on the core side. If it were up to me, I would have never supported Musepack, Ogg Vorbis, or any of this stuff.

[Tatsuya79]

Well, at least one open source format such as ogg is nice to have. Uncompressed audio is such a waste of space, particularly for mobile platform.

Websites with bad dumps are still there even for roms.

[Tatsuya79]

I did a revert HEAD~5 back to the "Remove MD5" commit and now ogg are working.

For wav I'm at a loss with strange results; I should test more with a real iso (without dis-embedded audio files).

[inactive123]

Can you actually track down at which point ogg no longer works, or did it occur exactly after HEAD~5?

[Tatsuya79]

"Downsize tremor" is the commit breaking it.

[Tatsuya79]

About the WAV case, in win7 x64, they always crash and tell: "Retroarch [libretro ERROR] unsupported audio track file format: 01.wav" Even when going back to a January version of pce_fast core.

Those cue+iso+WAV are working in Mednafen stand-alone. I'm wondering if that ever worked in Retroarch or if I always used OGG version? Or did it broke way earlier?

[inactive123]

Its not so much a regression as it is that we took wav plus the dependency that came with it out.

I guess we could add it back again for those dumped cds that need it, but still, this support every cd format plus the kitchensink is very annoying since it pretty much ensures bloat in the core and divergent cd dumps.

[Tatsuya79]

Tested working since Revert "Downsize tremor" commit. Closing this.

[inactive123]

What about the ISO+WAV issues?

[Tatsuya79]

Yes I can keep it opened for that, sure.

[Tatsuya79]

I could test a cue+iso without external audio files and it worked.

[rdbaaa]

I'm having this problem on Win10 -- instant crash as soon as the cue is chosen (the audio is wav). RA 1.3.4 and latest core from the updater. The log doesn't appear to be a ton of help since it crashes before it gets a chance to list anything. My hardware is an Intel NUC with Intel Graphics 520 and driver updates haven't fixed it either.

However, it works perfectly fine on a 2010 laptop that's on Intel but also Win10 -- same builds and configs. Perhaps it's just a case of too-new hardware. log.txt

[dasbootbee]

Hey guys. I'm noticing the same issue using 1.3.6. When I load a CUE/WAV format game RetroArch crashes immediately. The last entry in the log says RetroArch [libretro INFO] :: Loading... Then CTD.

CCD/IMG formatted games are fine. These CUE/WAV images also work in vanilla mednafen.

[Tatsuya79]

Fixed with https://github.com/libretro/beetle-pce-fast-libretro/commit/fc0cf49fe6f301b4958c9960c00a3bf7fcc2e9b6