libretro / beetle-pce-fast-libretro

Standalone fork of Mednafen PCE Fast to libretro
GNU General Public License v2.0
29 stars 56 forks source link

Update core to 1.23.0 #125

Closed ToniBC closed 2 years ago

ToniBC commented 5 years ago

Mednafen was recently updated with several corrections of this emulator and it would be nice to include them to improve those small errors. I don't know if some have already been applied, but since the core only reflects that it is in 0.9.38.7 Fast, they supposedly were not added.

After 0.9.38.7 this is what they changed:

As always, thank you very much for the effort and this is only to remember that it is pending to update the core.

mrjschulte commented 4 years ago

Had a quick look at doing this and the amount of work needed is not insignificant.

hizzlekizzle commented 4 years ago

That's a shame, but thanks for looking into it :)

ToniBC commented 4 years ago

Not everything has to be done at one time, little by little it can be improved to update it, it is what happens when the projects "leave" for a long time.

I left this to remember that a revision is needed so that this core is at the same level as the base and that the emulation is better.

But anyway, thanks for looking a little.

negativeExponent commented 4 years ago

the core is base on pce_fast, which with its libretro modifications can be called pce_fast_fast (yeah). So removing issue only for PCE and SuperGrafx, these are the relevant changes:

PCE, PSX, PCE_FAST: Avoid UB by biasing uintptr_t values instead of pointers directly in the CPU core. PCE, PCE_FAST: Added a missing sound emulation variable to save states. PCE_FAST: Fixed fubared mouse emulation.

doesn't look like game-breaking atm though without them. will probably look into it sometime unless someone does it first (does anyone care here about states compatibility, coz that will break with the changes)

ToniBC commented 4 years ago

This I published 1 year ago, when the other core was not there or the two branches were together, the PCE and PCE Fast. That is why the changes are included in the two cores.

negativeExponent commented 4 years ago

looking at past PR's, it seems that i have already addressed these before

I skipped save states coz it will break compatibility. So, its just a matter of bumping the version number which i havent done coz there is really nothing much related changes to the core since 9.39.2

negativeExponent commented 4 years ago

needless to say, since the missing save states are not harming anything atm. its probably safe for this to close until some major updates are pushed upstream.