libretro / beetle-pce-fast-libretro

Standalone fork of Mednafen PCE Fast to libretro
GNU General Public License v2.0
29 stars 55 forks source link

[merge conflicts] update libchdr based on latest upstream #163

Closed negativeExponent closed 3 years ago

negativeExponent commented 4 years ago

May (or may not) fix a few chd-related issues listed below. It doesn't hurt if doesn't fix in any case:

https://github.com/libretro/beetle-pce-fast-libretro/issues/157 https://github.com/libretro/beetle-pce-fast-libretro/issues/129 https://github.com/libretro/beetle-pce-fast-libretro/issues/80

Related libchdr update that fixes at least 1 issue: https://github.com/libretro/pcsx_rearmed/commit/9c659ffe685d5615b15c31cd86814e597cff7488

Related issue with regards to dependency resync: https://github.com/rtissera/libchdr/issues/24

inactive123 commented 4 years ago

@negativeExponent Do not close this. I very much want to merge this but we will first have to make sure that libchdr on both RetroArch and this repo are on the same page. Have some patience please.

And again, if there are issues, let's talk about it in DM. As it is, closing issues like this here is just going to be inconveniencing users in the end. I really think there has been some big misunderstanding here and I'm willing to work it out over DM.

negativeExponent commented 3 years ago

due to structure changes on upstream, this is probably irrelevant to merge unless updated.

negativeExponent commented 3 years ago

update to latest upstream changes, but retains folder structure and filename changes to still comply to current layout

NOTE: dependencies not updated.

negativeExponent commented 3 years ago

im discontinuing this. im gettng merge conflicts now.

inactive123 commented 3 years ago

@negativeExponent No worries, @rtissera will make sure libchdr in this and other cores gets updated

inactive123 commented 3 years ago

@rtissera can you fix this up?

inactive123 commented 3 years ago

Or should it be closed?

negativeExponent commented 3 years ago

this is outdated. and core already have merge latest deps and libchdr.

closing this then to avoid confusion.