Update libchdr (replace libflac with dr_flac) + fixes

libretro / beetle-pce-fast-libretro

Standalone fork of Mednafen PCE Fast to libretro

GNU General Public License v2.0

29 stars 55 forks source link

Update libchdr (replace libflac with dr_flac) + fixes #183

Closed jdgleaver closed 3 years ago

jdgleaver commented 3 years ago

This PR makes the following changes:

libchdr has been updated to the latest upstream version. The main benefit here is that libflac is replaced by dr_flac (https://mackron.github.io/dr_flac). This removes a vast amount code (~40k sloc), and also reduces the performance overheads of flac decoding by ~15%.
Significant memory leaks associated with CD image handling have been been fixed
A video buffer memory leak has been fixed
The CD Image Cache core option has been fixed

This closes #150

lgtm-com[bot] commented 3 years ago

This pull request fixes 2 alerts when merging a397719fecc2b7ae4b0542d7b4ec85c560071c8e into bc3160762561bb632276ee1ff527f2b45dc8ac6e - view on LGTM.com

fixed alerts:

1 for Resource not released in destructor
1 for Multiplication result converted to larger type